[#5817] core(feat): Add server-side REST APIs for model management #5948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Dec 25, 2024
server/src/main/java/org/apache/gravitino/server/web/rest/ModelOperations.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/gravitino/server/web/rest/ModelOperations.java
Outdated
Show resolved
Hide resolved
mchades
reviewed
Dec 25, 2024
| Preconditions.checkArgument( | ||
| StringUtils.isNotBlank(alias), "alias must not be null or empty"); | ||
| Preconditions.checkArgument( | ||
| !NumberUtils.isCreatable(alias), "alias must not be a number or a number string"); |
There was a problem hiding this comment.
why alias must not be a number or a number string? I don't see the limitation comment at the ModelVersion API
There was a problem hiding this comment.
It is because of the current implementation limitation, both the version and the alias will be treated as a part of NameIdentifier, if the name can be parsed as a number, then it will be treated as a version number, to avoid this ambiguity, I added this limitation. I can add the javadoc if needed.
common/src/main/java/org/apache/gravitino/dto/responses/ModelVersionListResponse.java
Show resolved
Hide resolved
server/src/main/java/org/apache/gravitino/server/web/rest/ModelOperations.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/gravitino/server/web/rest/ModelOperations.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/gravitino/server/web/rest/ModelOperations.java
Outdated
Show resolved
Hide resolved
jerryshao
force-pushed
the
issue-5817
branch
from
d6e33de to
59e5333
Compare
mchades
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the server-side REST endpoint for model management.
Why are the changes needed?
This is a part of model management for Gravitino.
Fix: #5817
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add UTs for this PR.