[ #4943] Update from feedback on Gravitino CLI demo #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # clients/cli/README.md # clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
justinmclean
changed the title
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java # clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateGroup.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateTag.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateUser.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteGroup.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteTag.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteUser.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/GroupDetails.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListAllTags.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListEntityTags.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListGroups.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTagProperties.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListUsers.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/RemoveTagProperty.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/SetTagProperty.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/TagDetails.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/TagEntity.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/UntagEntity.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/UpdateTagComment.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/UpdateTagName.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestFulllName.java # docs/cli.md
|
@shaofengshi I've merged main into this and it ready for review. |
…and fix group commands.
shaofengshi
reviewed
Nov 11, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteGroup.java
Outdated
Show resolved
Hide resolved
shaofengshi
reviewed
Nov 11, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteTag.java
Show resolved
Hide resolved
shaofengshi
reviewed
Nov 11, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteUser.java
Outdated
Show resolved
Hide resolved
shaofengshi
reviewed
Nov 11, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteUser.java
Show resolved
Hide resolved
shaofengshi
reviewed
Nov 11, 2024
|
Please update the PR title to reflect what you really did. Also #4943 doesn't reflect what this PR is, please create a new issue for this. |
justinmclean
changed the title
|
Created issue #5537 for this PR and updated title. |
|
@shaofengshi / @jerryshao waiting for further comments or merge from you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Feedback arising from the demo including:
Why are the changes needed?
Update from demo.
Fix: #5537
Does this PR introduce any user-facing change?
Delete commands and rename metalake now ask the user are you sure.
How was this patch tested?
Locally.