[#5131] Support tags in CLI #5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # clients/cli/README.md # clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
fix comments
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java
# Conflicts: # clients/cli/src/main/java/org/apache/gravitino/cli/CommandEntities.java # clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateGroup.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateUser.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteGroup.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteUser.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/GroupDetails.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListGroups.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListUsers.java # clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestCommandEntities.java # docs/cli.md
|
@shaofengshi @jerryshao This PR is ready for review. I've merged main into this branch, fixed the conflicts, and retested all of the tag commands and they are working as expected. |
shaofengshi
reviewed
Nov 8, 2024
shaofengshi
reviewed
Nov 8, 2024
shaofengshi
reviewed
Nov 8, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
Outdated
Show resolved
Hide resolved
shaofengshi
reviewed
Nov 8, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java
Show resolved
Hide resolved
|
@shaofengshi for you to review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for tags in the CLI.
Why are the changes needed?
To add support for tags in CLI.
Fix: # (issue)
Does this PR introduce any user-facing change?
Yes, it expands on the command line and adds new commands dealing with tags.
How was this patch tested?
Compiled locally.