-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): support building python on windows #1885
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Junduo Dong <[email protected]>
Hi @An-DJ , it this PR ready for review? |
No, CI result is fake, the build script didn't have been executed successfully. We need more works on windows platform... I will continue this PR in the next few days (too busy in this week...) |
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
I don't know why this enum make build failed... but successed if renaming it to FuryLogLevel::ERR Signed-off-by: Junduo Dong <[email protected]>
* pyfury/_serialization.pyd * pyfury/_util.pyd * pyfury/format/_format.pyd * pyfury/lib/mmh3/mmh3.pyd Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
Signed-off-by: Junduo Dong <[email protected]>
@chaokunyang This UT is strange.
I test it on Ubuntu 20.04 and Windows 10, but there are different result:
The point is that In addition, in
Could you plz give me some advice? |
Is Windows a big endian machine? |
You means the github windows-2022 ci runner is hosted on a big endian machine? No. According to the related document, for Linux and Windows runners, GitHub uses Dadsv5-series virtual machines. For more information, see Dasv5 and Dadsv5-series in the Microsoft Azure documentation.
|
@chaokunyang Actually we check the python array initialization method IMHO it is the reason why it behaves differently on UNIX and Windows. Ref: https://docs.python.org/3/library/array.html We should find a strict way to fix each dtype size... right? |
Yeah, you are right. Fury take |
What does this PR do?
Support building python on Windows.
Related issues
Close #798
Does this PR introduce any user-facing change?
Benchmark