[BP-1.20][FLINK-34227][runtime] Makes the JobMaster close procedure more robust to IO thread leaks from the scheduler side #26115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#24489) * Makes stopping the job execution in JobMaster run in the main thread * Makes JobMaster#closeAsync more robust to disconnect calls during shutdown * Adds test to cover FLINK-34227 scenario
…duler instance (i.e. the JobMaster) - Adds test for checking whether the scheduler closing leaks an IO thread via the CheckpointsCleaner to the *SchedulerTests - Makes CheckpointsCleaner available in AdaptiveBatchSchedulerFactory.createScheduler
XComp
commented
Feb 6, 2025
| @@ -204,6 +205,7 @@ public static AdaptiveBatchScheduler createScheduler( | |||
| ScheduledExecutorService futureExecutor, | |||
| ClassLoader userCodeLoader, | |||
| CheckpointRecoveryFactory checkpointRecoveryFactory, | |||
| CheckpointsCleaner checkpointsCleaner, | |||
| Time rpcTimeout, | |||
There was a problem hiding this comment.
Here's where the conflict appeared: Duration needed to be changed to Time
XComp
changed the title
|
I merged this one w/o an approval because the code change was approved in the parent PR, the conflict was minor and CI was successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combined PR of the two parent PRs #24489 and #26095
There was one minor conflict related to the Time/Duration refactoring that happened in 2.0