Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34227][runtime] Ensure that the scheduler close call doesn't leak IO threads into the JobMaster #26095

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Jan 31, 2025

What is the purpose of the change

This is a follow-up PR of #24489 based on @zentol 's comment. Check the PR #24489 for more context.

This PR focuses on fixing the IO thread leakage on the SchedulerNG side.

Brief change log

  • Introduces new FutureUtils method for an async compose.
  • Make checkpointsCleaner operation complete in the main thread for AdaptiveScheduler and SchedulerBase

Verifying this change

  • Adds test method to AdaptiveSchedulerTest, DefaultSchedulerTest and AdaptiveBatchSchedulerTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

XComp added 2 commits January 31, 2025 13:04
…ing leaks an IO thread via the CheckpointsCleaner to the *SchedulerTests
@XComp XComp changed the title Flink 34227 scheduler close [FLINK-34227][runtime] Ensure that the scheduler close call doesn't leak IO threads into the JobMaster Jan 31, 2025
@airlock-confluentinc airlock-confluentinc bot force-pushed the FLINK-34227-scheduler-close branch from 201c979 to 04a3dca Compare January 31, 2025 12:44
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 31, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants