Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37087][doc] Add docs for alter materialized table as query #26064

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hackergin
Copy link
Contributor

@hackergin hackergin commented Jan 23, 2025

What is the purpose of the change

Add docs for alter materialized table as query

Brief change log

  • Add docs for alter materialized table as query

Verifying this change

This change only contains document change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@hackergin hackergin force-pushed the FLINK-37087 branch 4 times, most recently from 3217e5f to 9036d53 Compare January 23, 2025 13:08
Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the REFRESH keyword is mentioned - there is a some explanation of this in the file but not how the partition piece works and when you would want to use it.
I see we have added SUSPEND and RESUME, it would be useful to describe or link to how these work - including how the supplied list of keys should be used.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 23, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@hackergin hackergin force-pushed the FLINK-37087 branch 3 times, most recently from bc40df2 to 38fd3d0 Compare January 24, 2025 08:50
@davidradl
Copy link
Contributor

Reviewed by Chi on 23/01/2025 Go back to the submitter with review comments.

Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackergin Thanks for your contribution, I left some comments.

@hackergin
Copy link
Contributor Author

I see that the REFRESH keyword is mentioned - there is a some explanation of this in the file but not how the partition piece works and when you would want to use it. I see we have added SUSPEND and RESUME, it would be useful to describe or link to how these work - including how the supplied list of keys should be used.

@davidradl This document is solely intended to explain how users can use it. If we need to introduce the underlying implementation to users, I think we should have a separate document to explain the overall process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants