-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-31860] Ignore Event creation errors during cleanup #577
Conversation
I still need to test this on minikube and make sure that ignoring event errors is enough during namespace deletion or whether we also need to handle status updates the same way |
Unfortunately this still doesn't address the original issue. Even if we ignore all errors (event creation and others we still get the following JOSDK error)
|
Closing this for now, there seem to be a bigger underlying problem outside the flink operator . More details here: operator-framework/java-operator-sdk#1876 |
What is the purpose of the change
The current logic tries to create Kubernetes events even during cleanup steps, failing to create them leads to a retry loop and a stuck delete operation on the CR.
However in many cases it's not possible to create events at this stage such as when a namepsace deletion triggered the CR deletion. Currently this means that namespace deletion will be blocked by the stuck cleanup/delete operation.
This PR addresses this by allowing us to ignore event creation errors during the cleanup phase.
Brief change log
Verifying this change
New tests added for the FlinkDeployment and FlinkSessionJob controllers
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors
: noDocumentation