Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-30470][build] Change groupId for flink-connector-parent #95

Merged
merged 2 commits into from
Oct 16, 2023
Merged

[FLINK-30470][build] Change groupId for flink-connector-parent #95

merged 2 commits into from
Oct 16, 2023

Conversation

ruanhang1993
Copy link
Contributor

Purpose of the change

Change groupId for flink-connector-parent.

Verifying this change

This change is already covered by existing tests

Significant changes

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced
    • If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 12, 2023

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

hlteoh37
hlteoh37 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@hlteoh37 hlteoh37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ruanhang1993

dannycranmer
dannycranmer approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@dannycranmer dannycranmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@dannycranmer dannycranmer merged commit 01f112b into apache:main Oct 16, 2023
1 check passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 16, 2023

Awesome work, congrats on your first merged pull request!

@dannycranmer dannycranmer mentioned this pull request Oct 18, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannycranmer dannycranmer dannycranmer approved these changes

@hlteoh37 hlteoh37 hlteoh37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruanhang1993 @dannycranmer @hlteoh37