[FLINK-36523][Connectors/DynamoDB][BugFix] Fixing LATEST behaviour for DDB Connector #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlteoh37
reviewed
Oct 14, 2024
Comment on lines
106
to
111
| * also, all the ancestors will not be tracked and rather only the current open shard will be | ||
| * tracked with LATEST. |
There was a problem hiding this comment.
I don't think this is correct. When restoring from snapshot, we should read all records since the restored snapshot (TRIM_HORIZON), and not LATEST.
There was a problem hiding this comment.
We should align that the expected behavior, when using LATEST, should be:
- When starting without snapshot:
- All shards from start of application read from
LATEST. If we want, we can focus on just the open shards. - All child shards are read from
TRIM_HORIZON
- All shards from start of application read from
- When reading with snapshot:
- All shards from time of start of application are read from
TRIM_HORIZON
- All shards from time of start of application are read from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Fixing latest behaviour for DDB Connector.
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
Added new unit tests
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))