Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36428][Connectors/DynamoDB] DynamoDb Table API Sink fails when null value in the RowData #173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maoxingda
Copy link

@maoxingda maoxingda commented Oct 7, 2024

Purpose of the change

Add an option ignore-nulls to determine whether to ignore null values, instead of hardcoding it into the code.

image

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment
  • Added unit tests
  • Manually verified by running the Kinesis connector on a local Flink cluster.

Significant changes

(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced
    • If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)

Copy link

boring-cyborg bot commented Oct 7, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@maoxingda maoxingda changed the title [Connectors/DynamoDB] DynamoDb Table API Sink fails when null value in the RowData [FLINK-36428][Connectors/DynamoDB] DynamoDb Table API Sink fails when null value in the RowData Oct 7, 2024
@maoxingda maoxingda force-pushed the fix/nullable branch 2 times, most recently from 841aaf7 to 2ef2e8e Compare October 7, 2024 03:07
@maoxingda
Copy link
Author

Could someone help review this pull request?

Copy link
Contributor

@hlteoh37 hlteoh37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants