[FLINK-31922][Connectors/AWS] Port over Kinesis Client configurations for retry and backoff strategies #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karubian
changed the title
Closed
4 tasks
hlteoh37
reviewed
Sep 17, 2024
hlteoh37
reviewed
Sep 17, 2024
...connector-aws-base/src/main/java/org/apache/flink/connector/aws/config/AWSConfigOptions.java
Show resolved
Hide resolved
hlteoh37
reviewed
Sep 17, 2024
...c/main/java/org/apache/flink/connector/kinesis/source/config/KinesisSourceConfigOptions.java
Outdated
Show resolved
Hide resolved
… for retry and backoff
karubian
force-pushed
the
kinesis-conf
branch
from
5b5de7e
to
570f3d2
Compare
hlteoh37
reviewed
Sep 18, 2024
Comment on lines
30
to
+31
| @Experimental | ||
| public class KinesisStreamsSourceConfigConstants { | ||
| @PublicEvolving |
There was a problem hiding this comment.
Hmmm, there's no point having both here - Only 1 is required. Because this connector is still @Experimental we can keep it that way 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Port over Kinesis Client configurations for retry and backoff
Contains the changes from this PR: #150
Verifying this change
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))