[FLINK-35401][Connectors/Sqs] Add Sqs Table API connector #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hlteoh37 could you please take a look? |
vahmed-hamdy
changed the title
hlteoh37
requested changes
Sep 11, 2024
|
|
||
| /** Options for the SQS connector. */ | ||
| @PublicEvolving | ||
| public class SqsConnectorOptions { |
There was a problem hiding this comment.
Can we merge this with SqsConfigConstants?
There was a problem hiding this comment.
We havent' released the connector, so let's make this uniform before we release it
There was a problem hiding this comment.
Hmm, can do but do we want to break the consistency with other AWS Table API connectors?
They are not merged for any of kinesis, firehose or DDB. I think it might be confusing for users since they are Public classes.
...s/flink-connector-sqs/src/main/java/org/apache/flink/connector/sqs/table/SqsDynamicSink.java
Show resolved
Hide resolved
vahmed-hamdy
force-pushed
the
FLINK-35401-sqs-table-api
branch
from
5400e44
to
90f6c8d
Compare
|
@hlteoh37 Thanks for the review, Addressed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Implements the Table API for the Sqs Sink Connector.
Verifying this change
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))