Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix][ci] Set AWS end-to-end tests to run on all push #100

Merged
merged 2 commits into from
Oct 2, 2023
Merged

[hotfix][ci] Set AWS end-to-end tests to run on all push #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c139e1
[hotfix][ci] Set AWS end-to-end tests to run on all push
hlteoh37 Oct 2, 2023
938c6cc
[hotfix][ci] Fix reference of Github secrets
hlteoh37 Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/workflows/common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,6 @@ on:
required: false
type: number
default: 50
run_aws_end_to_end_test:
description: "Whether to run the AWS end to end tests, requiring AWS credentials."
required: false
type: boolean
default: false

jobs:
compile_and_test:
Expand All @@ -60,8 +55,8 @@ jobs:
FLINK_CACHE_DIR: "/tmp/cache/flink"
MVN_BUILD_OUTPUT_FILE: "/tmp/mvn_build_output.out"
MVN_VALIDATION_DIR: "/tmp/flink-validation-deployment"
FLINK_AWS_USER: ${{ vars.FLINK_AWS_USER }}
FLINK_AWS_PASSWORD: ${{ vars.FLINK_AWS_PASSWORD }}
FLINK_AWS_USER: ${{ secrets.FLINK_AWS_USER }}
FLINK_AWS_PASSWORD: ${{ secrets.FLINK_AWS_PASSWORD }}
steps:
- run: echo "Running CI pipeline for JDK version ${{ matrix.jdk }}"

Expand Down Expand Up @@ -120,7 +115,7 @@ jobs:
mvn clean

- name: Run AWS e2e tests
if: ${{ inputs.run_aws_end_to_end_test }}
if: ${{ github.event_name == 'push' }}
run: |
set -o pipefail

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,3 @@ jobs:
flink_version: ${{ matrix.flink }}
flink_url: https://s3.amazonaws.com/flink-nightly/flink-${{ matrix.flink }}-bin-scala_2.12.tgz
cache_flink_binary: false
run_aws_end_to_end_test: true