-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-36858][pipeline-connector][kafka] Fix compatibility with Flink 1.20 JsonRowDataSerializationSchema #3784
base: master
Are you sure you want to change the base?
Conversation
@lvyanquan @yuxiqian cc~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution, left some minor comments.
...in/java/org/apache/flink/cdc/connectors/kafka/utils/JsonRowDataSerializationSchemaUtils.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/flink/cdc/connectors/kafka/utils/JsonRowDataSerializationSchemaUtils.java
Show resolved
Hide resolved
...in/java/org/apache/flink/cdc/connectors/kafka/utils/JsonRowDataSerializationSchemaUtils.java
Show resolved
Hide resolved
…SerializationSchema-compatibility-bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi @leonardBang @ruanhang1993 could you please help to trigger the CI? |
…SerializationSchema-compatibility-bug # Conflicts: # flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/pom.xml
…SerializationSchema-compatibility-bug
…SerializationSchema-compatibility-bug
@leonardBang please help trigger ci when you have time, thank~ |
pipeline.yml
In flink>=1.20, the constructor of JsonRowDataSerializationSchema has 6 parameters, and in flink<1.20, the constructor of JsonRowDataSerializationSchema has 5 parameters.