41-unique-log-id #47
Merged
41-unique-log-id #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…init, test basic functionality
rc10house
suggested changes
Jul 9, 2024
distill/core/log.py
Outdated
| @@ -46,7 +47,8 @@ def __init__(self, data: Union[str, JsonDict], schema=UserAleSchema): | |||
| raise TypeError("ERROR: " + str(type(data)) + " data should be either a string or a JsonDict") | |||
| self.data = schema(**data) | |||
|
|
|||
| # TODO: need to create ID field here on object initialization | |||
| self.id = PKSUID("log", schema._timestamp(self.data)) | |||
There was a problem hiding this comment.
Bake the userId into the PKSUID as Evan mentioned in the call to make the log truly globally unique. Ex: log_userId_hash
| @@ -44,6 +44,10 @@ def test_log_constructor(): | |||
| pageUrl = test_log.data.page_url | |||
| assert pageUrl == "https://github.com/apache/flagon/tree/master/docker" | |||
|
|
|||
| id = test_log.id | |||
| assert id.get_timestamp() == 1719530111079 // 1000 | |||
There was a problem hiding this comment.
As long as this passes it is fine, but I do not use floor division when parsing the timestamp. Just a nit pick though
EandrewJones
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.