42-normalize-timestamp #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EandrewJones
requested changes
Jul 2, 2024
added 2 commits
July 2, 2024 18:59
EandrewJones
approved these changes
Jul 3, 2024
| @@ -58,7 +58,7 @@ class UserAleSchema(BaseModel): | |||
| page_title: str | |||
| page_referrer: str | |||
| browser: Browser | |||
| client_time: int | |||
| client_time: int | |||
There was a problem hiding this comment.
why the trailing space?
| @@ -19,8 +19,9 @@ | |||
|
|
|||
| from pydantic import ValidationError | |||
|
|
|||
| from distill.core.log import Log | |||
| from distill.core.log import Log | |||
Comment on lines
+74
to
+82
|
|
||
| @field_validator("client_time") | ||
| def validate_ct(cls, ct: float): | ||
| return datetime.fromtimestamp(ct / 1000) | ||
|
|
||
| @field_serializer("client_time") | ||
| def serialize_ct(self, ct: datetime): | ||
| return int(ct.timestamp() * 1000) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timestamp normalization function for use in log ID creation. The function can accept arbitrary timestamps and timezones and will attempt to normalize to a python date time object (defaults to +0000 timezone). The function can also accept POSIX timestamps (seconds or milliseconds since the epoch).
Closes #42