Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-1221 Fix Client SDK Broken Methods #4078

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

henriquepaes1
Copy link

Description

Retrofit does not allow HTTP Body in Delete operations. However, some Resources classes had an @RequestBody Swagger annotation, which added a body to retrofit interfaces, therefore the method threw the mentioned exception. Once I validated that the requests never used the body, I fixed the methods by removing the @RequestBody annotation.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@galovics
Copy link
Contributor

galovics commented Oct 4, 2024

@henriquepaes1 the build is failing due to formatting errors. pls run a ./gradlew spotlessApply and repush the code (squashing the commits into one)

@henriquepaes1
Copy link
Author

@galovics Just did it :)

FINERACT-1221 Fix Client SDK Broken Methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants