Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-2081: Skip loan processing if no overdue #4066

Conversation

kulminsky
Copy link
Contributor

@kulminsky kulminsky commented Sep 18, 2024

Description

Describe the changes made and why they were made.

  • When there is no overdue penalty available and no overdue installment, do not reprocess the loan
  • Enhance retrieveAllOverdueInstallmentsForLoan logic, if there is no penalty charge configured on the loan, do not iterate through on the installments

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy
Copy link
Contributor

@kulminsky I reckon you wanted to use FINERACT-2081 instead of FINERACT-2038 ;)

@kulminsky kulminsky force-pushed the FINERACT-2038-skip_loan_processing_if_no_overdue branch from ab4f664 to 28fa61f Compare September 24, 2024 08:21
@kulminsky kulminsky changed the title FINERACT-2038: Skip loan processing if no overdue FINERACT-2081: Skip loan processing if no overdue Sep 24, 2024
@kulminsky kulminsky force-pushed the FINERACT-2038-skip_loan_processing_if_no_overdue branch 3 times, most recently from 792bb6d to 3aef345 Compare September 25, 2024 14:32
@kulminsky kulminsky closed this Sep 25, 2024
@kulminsky kulminsky force-pushed the FINERACT-2038-skip_loan_processing_if_no_overdue branch from 3aef345 to 889fc8d Compare September 25, 2024 14:40
@kulminsky kulminsky reopened this Sep 25, 2024
@kulminsky kulminsky marked this pull request as ready for review September 25, 2024 14:48
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit b68149c into apache:develop Sep 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants