Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3] Retry connect to provider server by catching ClosedChannelException #15209

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Mar 6, 2025

What is the purpose of the change?

try to fix #15191
@AlbumenJ

... catch such exception and retry automatically. In the future, maybe 3.4, we can remove all the support of netty3 anymore. It is important to prevent importing surprising changes in minor release.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 38.09524% with 26 lines in your changes missing coverage. Please review.

Project coverage is 60.77%. Comparing base (91b005e) to head (b9a14d5).
Report is 1 commits behind head on 3.3.

Files with missing lines Patch % Lines
...he/dubbo/remoting/transport/netty/NettyClient.java 38.09% 21 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15209      +/-   ##
============================================
+ Coverage     60.76%   60.77%   +0.01%     
- Complexity    10886    10892       +6     
============================================
  Files          1885     1885              
  Lines         86071    86082      +11     
  Branches      12892    12894       +2     
============================================
+ Hits          52298    52316      +18     
+ Misses        28326    28314      -12     
- Partials       5447     5452       +5     
Flag Coverage Δ
integration-tests 33.14% <0.00%> (+0.05%) ⬆️
samples-tests 29.08% <0.00%> (-0.11%) ⬇️
unit-tests 58.93% <38.09%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw force-pushed the 3.3-Optimized-catchClosedChannelException4NettyClient branch from 7a92b27 to cf3f3bf Compare March 6, 2025 08:39
@zrlw zrlw force-pushed the 3.3-Optimized-catchClosedChannelException4NettyClient branch from cf3f3bf to b9a14d5 Compare March 7, 2025 01:36
if (logger.isInfoEnabled()) {
logger.info("Close old netty channel " + oldChannel + " on create new netty channel "
+ newChannel);
while (true) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should limit the maximum times here


if (cause instanceof ClosedChannelException) {
// Netty3.2.10 ClosedChannelException issue, see https://github.com/netty/netty/issues/138
connectTimeout = deadline - System.currentTimeMillis();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlbumenJ
connectTimeout will be recalculated at here.

@AlbumenJ AlbumenJ merged commit 243da4d into apache:3.3 Mar 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] netty 3.2.10 that dubbo-remoting-netty currently depended has a known client connect exception issue
3 participants