-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.3] Retry connect to provider server by catching ClosedChannelException #15209
[3.3] Retry connect to provider server by catching ClosedChannelException #15209
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15209 +/- ##
============================================
+ Coverage 60.76% 60.77% +0.01%
- Complexity 10886 10892 +6
============================================
Files 1885 1885
Lines 86071 86082 +11
Branches 12892 12894 +2
============================================
+ Hits 52298 52316 +18
+ Misses 28326 28314 -12
- Partials 5447 5452 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7a92b27
to
cf3f3bf
Compare
cf3f3bf
to
b9a14d5
Compare
if (logger.isInfoEnabled()) { | ||
logger.info("Close old netty channel " + oldChannel + " on create new netty channel " | ||
+ newChannel); | ||
while (true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should limit the maximum times here
|
||
if (cause instanceof ClosedChannelException) { | ||
// Netty3.2.10 ClosedChannelException issue, see https://github.com/netty/netty/issues/138 | ||
connectTimeout = deadline - System.currentTimeMillis(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlbumenJ
connectTimeout will be recalculated at here.
What is the purpose of the change?
try to fix #15191
@AlbumenJ
Checklist