Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3] Optimized EagerThreadPoolExecutorTest by decreasing maximumPoolSize #15205

Merged

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Mar 4, 2025

What is the purpose of the change?

try to fix #15204

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.79%. Comparing base (3771339) to head (8fcd1cc).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15205      +/-   ##
============================================
+ Coverage     60.78%   60.79%   +0.01%     
- Complexity    10888    10889       +1     
============================================
  Files          1885     1885              
  Lines         86071    86071              
  Branches      12892    12892              
============================================
+ Hits          52315    52324       +9     
+ Misses        28308    28303       -5     
+ Partials       5448     5444       -4     
Flag Coverage Δ
integration-tests 33.14% <ø> (+<0.01%) ⬆️
samples-tests 29.20% <ø> (+0.02%) ⬆️
unit-tests 58.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrlw zrlw force-pushed the 3.3-Optimized-EagerThreadPoolExecutorTest branch from f91c9b7 to 8fcd1cc Compare March 5, 2025 04:11
@AlbumenJ AlbumenJ merged commit 25d6872 into apache:3.3 Mar 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] the waiting time of EagerThreadPoolExecutorTest#testEagerThreadPoolFast is insufficient
3 participants