[Feature 3.3] Triple Rest Cors Support #14073

Rawven · 2024-04-12T07:30:33Z

What is the purpose of the change

issue [#13965 ]
I have added a demo test for this new feature to the 3.3-triple-cors branch of the fork's dubbo-sample repository, and used the sample repository to pass ci on my own branch. This is link Rawven#7

Brief changelog

Verifying this change

Checklist

Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
Add some description to dubbo-website project if you are requesting to add a feature.
GitHub Actions works fine on your own branch.
If this contribution is large, please follow the Software Donation Guide.

3.3

…-cors

oxsean · 2024-05-20T06:02:17Z

@AlbumenJ LGTM.

...o-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsHeaderFilter.java

…-cors

Rawven · 2024-05-21T07:55:29Z

@AlbumenJ PTAL
I have fix the license,but it looks like the latest commit of the integration test will make the workflow fail

EarthChen · 2024-05-22T02:48:51Z

dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/HeaderFilter.java

@@ -22,5 +22,5 @@
 @SPI(scope = ExtensionScope.FRAMEWORK)
 public interface HeaderFilter {

-    RpcInvocation invoke(Invoker<?> invoker, RpcInvocation invocation) throws RpcException;
+    void invoke(Invoker<?> invoker, RpcInvocation invocation) throws RpcException;


why change this api?

I didn't notice that this API was introduced in 3.0. indeed shouldn't be modified, I'll revert it later. However, this return value not being used.

Revert have done

sonarqubecloud · 2024-05-22T05:23:07Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

EarthChen

LGTM

Rawven and others added 27 commits April 8, 2024 12:41

feat(): add cors key

96b82c2

feat(): add base cors class

513789a

feat(): add cors class in rpc-triple and rest-spring

6897c8f

feat(): add cors class in rpc-triple and rest-spring

a21d7a2

test(): add rpc-triple cors test

f6594c5

fix(): fix CorsUtil bug

cf42edb

fix(): fix CorsUtil bug

352e974

fix(): fix objectUtil bug

32015a3

fix(): fix corsmeta set bug

c785a5e

fix(): fix config load fail bug

194bbc5

fix(): option method can not be look fail

995b87b

fix(): CorsMeta method will null

f45cc0c

fix(): request-header not set will fail

755d39b

refactor(): improve CorsMeta CorsProcess some code

7efd588

fix(): coreMeta combine priority

e743a54

test(): remove rest-spring cors test to sample

5445bbe

docs(): add docs

d089ad3

revert(): test version

e64fad4

fix(): getCorsMeta can be null

342c64f

fix(): combine can be null

8137167

fix(): save option and vary bug

791c905

fix(): pom version

81fff53

fix(): spring version will cause allowPrivateWork resolve error

8be4988

fix(): ci

a93b3e8

Merge branch '3.3-triple-cors' into 3.3

fd60c82

Merge pull request #4 from Rawven/3.3

e1fb1e7

3.3

refactor(): delete useless code

fa1020e

oxsean self-requested a review April 12, 2024 13:59

Rawven added 2 commits April 12, 2024 22:53

refactor(): accept some sonarcloud issue

8a4c279

refactor(): add @nullable to point the CorsMeta Attributes

5b44226

Rawven and others added 11 commits May 18, 2024 21:51

fix(): update unit test

8269417

fix(): fix unit test && Fix cors specification

9be5013

Merge branch '3.3' into 3.3-triple-cors

e503110

fix(): fix pom

e90185f

fix(): fix combine bug

4385532

Merge remote-tracking branch 'origin/3.3-triple-cors' into 3.3-triple…

c0026bd

…-cors

fix(): fix some sonar issue

00aa06a

fix(): fix style

c4b501a

feat(rest): refine cors support

8bae639

fix(): fix style

88ebc5a

fix(): fix needed sonar issue

12d1b87

oxsean approved these changes May 20, 2024

View reviewed changes

refactor(): refactor CorsMeta.combine() and add comment

c04a61f

AlbumenJ requested changes May 21, 2024

View reviewed changes

...o-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/cors/CorsHeaderFilter.java Outdated Show resolved Hide resolved

Rawven and others added 6 commits May 21, 2024 13:00

fix(): Replenish license

c61a130

Merge branch '3.3' into 3.3-triple-cors

a9467cc

fix(): update test

6151c67

Merge remote-tracking branch 'origin/3.3-triple-cors' into 3.3-triple…

e399e92

…-cors

test(): Refactor the test class and add credential test cases

b7cb8c7

test(): Refactor the test class and add credential test cases

db4503b

Merge branch '3.3' into 3.3-triple-cors

1a9d770

AlbumenJ approved these changes May 22, 2024

View reviewed changes

EarthChen reviewed May 22, 2024

View reviewed changes

oxsean and others added 2 commits May 22, 2024 03:41

fix(rest): revert api HeaderFilter

edf9363

fix(): accept sonar issue

852ad86

EarthChen approved these changes May 23, 2024

View reviewed changes

EarthChen merged commit 1f6d441 into apache:3.3 May 23, 2024
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature 3.3] Triple Rest Cors Support #14073

[Feature 3.3] Triple Rest Cors Support #14073

Rawven commented Apr 12, 2024 •

edited

Loading

oxsean commented May 20, 2024

Rawven commented May 21, 2024 •

edited

Loading

EarthChen May 22, 2024

AlbumenJ May 22, 2024

oxsean May 22, 2024

Rawven May 22, 2024

sonarqubecloud bot commented May 22, 2024

EarthChen left a comment

[Feature 3.3] Triple Rest Cors Support #14073

[Feature 3.3] Triple Rest Cors Support #14073

Conversation

Rawven commented Apr 12, 2024 • edited Loading

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

oxsean commented May 20, 2024

Rawven commented May 21, 2024 • edited Loading

EarthChen May 22, 2024

Choose a reason for hiding this comment

AlbumenJ May 22, 2024

Choose a reason for hiding this comment

oxsean May 22, 2024

Choose a reason for hiding this comment

Rawven May 22, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented May 22, 2024

Quality Gate passed

EarthChen left a comment

Choose a reason for hiding this comment

Rawven commented Apr 12, 2024 •

edited

Loading

Rawven commented May 21, 2024 •

edited

Loading