Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not invoke test method(#13589) #13590

Closed
wants to merge 1 commit into from

Conversation

vio-lin
Copy link
Contributor

@vio-lin vio-lin commented Dec 29, 2023

What is the purpose of the change

there is a test method but execute by org.apache.dubbo.common.extension.ExtensionLoader#injectExtension

org.apache.dubbo.rpc.filter.ExceptionFilter#setLogger

image

Brief changelog

ignore test method when extensionLoader inject instance.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x ] Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

Please fix on 3.2.x branch

@vio-lin
Copy link
Contributor Author

vio-lin commented Jan 2, 2024

Please fix on 3.2.x branch
enen 🙆🏻

@CrazyHZM CrazyHZM closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants