Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.apache.zookeeper:zookeeper from 3.7.0 to 3.7.2 in /dubbo-dependencies-bom #13495

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 13, 2023

Bumps org.apache.zookeeper:zookeeper from 3.7.0 to 3.7.2.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps org.apache.zookeeper:zookeeper from 3.7.0 to 3.7.2.

---
updated-dependencies:
- dependency-name: org.apache.zookeeper:zookeeper
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the type/dependencies Pull requests that update a dependency file label Dec 13, 2023
@AlbumenJ
Copy link
Member

@oxsean PTAL

@AlbumenJ
Copy link
Member

Looks like log4j fail

@oxsean
Copy link
Collaborator

oxsean commented Dec 14, 2023

Looks like log4j fail

Version 3.7.2 has removed the transitive dependency of log4j. The dependency of slf4j-log4j12 needs to be added in many modules like version 3.3 for fix it, and this might impact the end-users. Are you sure we need to do this in a minor version update?

@AlbumenJ
Copy link
Member

Looks like log4j fail

Version 3.7.2 has removed the transitive dependency of log4j. The dependency of slf4j-log4j12 needs to be added in many modules like version 3.3 for fix it, and this might impact the end-users. Are you sure we need to do this in a minor version update?

That seems we can upgrade it on 3.3 and ignore it in 3.2?

@oxsean
Copy link
Collaborator

oxsean commented Dec 16, 2023

3.7.2

Yes, I think it's better to keep 3.7.0 in 3.2. I have already updated to 3.7.2 in 3.3 when supporting log4j2.

@AlbumenJ AlbumenJ closed this Dec 20, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 20, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/dubbo-dependencies-bom/org.apache.zookeeper-zookeeper-3.7.2 branch December 20, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants