Remove note about front-coded dictionaries #17705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
approved these changes
Feb 7, 2025
317brian
requested changes
Feb 7, 2025
| @@ -365,21 +365,6 @@ Check out the examples at [All Druid SQL functions](../querying/sql-functions.md | |||
|
|
|||
| ## Upgrade notes and incompatible changes | |||
|
|
|||
| ### Upgrade notes | |||
There was a problem hiding this comment.
line 368 needs to be added back
There was a problem hiding this comment.
@317brian I am not in favor of adding back a heading that will not have any content in it. Should we change the H2 to just say "Incompatible changes"?
Or put the heading back & mention "No upgrade notes to mention"
There was a problem hiding this comment.
We can delete it, but there's a reference to it somewhere, which is why the link checker is breaking
remove link to notes
317brian
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the upgrade note about front-coded dictionaries from the release notes.
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: