Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-8499: new util for creating random strings #2918

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

pjfanning
Copy link
Contributor

Description

DRILL-8499
Discussed in Drill mailing lists

Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Thanks @pjfanning!
Just a question, but is the license file addition necessary? The reason I ask is that I think there are a few other similar situations in Drill where we copied and slightly modified libraries that are licensed under an Apache license.

@pjfanning
Copy link
Contributor Author

@cgivre I'm involved in the Incubator PMC and the PMC members try to get all the podlings to be very explicit in their LICENCEs.

The Apache License basically requires you to copy the 3rd party Apache License and Notice into your License and Notice when you borrow code - even if you make some fairly large mods to it.

You don't need to duplicate the standard text of the license but things like copyrights should be copied.
The source header(s) from the original files should be preserved.

@cgivre cgivre merged commit 6564098 into apache:master Jun 26, 2024
8 checks passed
@pjfanning pjfanning deleted the random-utils branch June 27, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants