Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Update Calcite to 1.36 #2844

Closed
wants to merge 24 commits into from
Closed

Conversation

cgivre
Copy link
Contributor

@cgivre cgivre commented Nov 1, 2023

DRILL-XXXX: Update Calcite to 1.35

(Please replace PR Title with actual PR Title)

Description

(Please describe the change. If more than one ticket is fixed, include a reference to those tickets.)

Documentation

(Please describe user-visible changes similar to what should appear in the Drill documentation.)

Testing

(Please describe how this PR has been tested.)

@cgivre
Copy link
Contributor Author

cgivre commented Nov 2, 2023

@vvysotskyi @jnturton, I started experimenting with updating to Calcite 1.35 and there's some strange behavior that I could use some assistance with. Basically, for DECIMAL(), Calcite seems to be reversing the scale and precision. I'm not quite sure even where to start with this. Could you point me in the right direction?

@cgivre cgivre self-assigned this Nov 2, 2023
@vvysotskyi
Copy link
Member

@cgivre, I think to fix it there are required changes in DrillRexBuilder.makeCast to accept and pass further boolean safe param. Here are some of my changes for update I tried long time ago: master...vvysotskyi:drill:calcite-1.35-test

cgivre and others added 22 commits November 2, 2023 11:39
Bumps [h2](https://github.com/h2database/h2database) from 2.1.210 to 2.2.220.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](h2database/h2database@version-2.1.210...version-2.2.220)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…apache#2822)

* Shut down MiniDFS cluster in TestInboundImpersonation.selectChainedView.

* Ensure that MiniDFS is using simple auth in BaseTestImpersonation.
* Upgrade Hadoop to 3.3.6.
* Upgrade Apache Phoenix libs to 5.1.3
…32.1.2-jre (apache#2827)

* Remove Drill's shaded Guava.
* Upgrade Guava 30.1.1-jre → 32.1.2-jre.
* Suppress checkstyle warnings of "Unable to locate Source XRef".
…pache#2839)

* Add a 2GB swap file when setting up the Actions Runner.
* Remove /proc/sys/vm/drop_caches snake oil.
* Tune the heap and direct memory limits applied to the test suite.
@cgivre cgivre changed the title [DRAFT] Update Calcite to 1.35 [DRAFT] Update Calcite to 1.36 Jan 8, 2024
@cgivre cgivre closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants