Exclude Guava patcher from the default-hadoop profile.

apache · Aug 18, 2023 · 5c79786 · 5c79786
1 parent d0d4a83
commit 5c79786
Show file tree

Hide file tree

Showing 7 changed files with 48 additions and 20 deletions.
diff --git a/common/pom.xml b/common/pom.xml
@@ -100,6 +100,46 @@
 
   </dependencies>
 
+  <profiles>
+    <profile>
+      <id>default-hadoop</id>
+      <activation>
+        <activeByDefault>true</activeByDefault>
+      </activation>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-compiler-plugin</artifactId>
+            <version>3.11.0</version>
+            <configuration>
+              <excludes>
+                <!-- Guava is only patched for Hadoop 2 -->
+                <exclude>org/apache/drill/common/util/GuavaPatcher.java</exclude>
+              </excludes>
+              <testExcludes>
+                <!-- Guava is only patched for Hadoop 2 -->
+                <testExclude>org/apache/drill/common/util/TestGuavaPatcher.java</testExclude>
+              </testExcludes>
+            </configuration>
+          </plugin>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-surefire-plugin</artifactId>
+              <configuration>
+                <excludes>
+                  <exclude>org/apache/drill/common/util/TestGuavaPatcher.java</exclude>
+                </excludes>
+              </configuration>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+    <profile>
+      <id>hadoop-2</id>
+    </profile>
+  </profiles>
+
   <build>
     <plugins>
       <plugin>

diff --git a/common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java b/common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java
@@ -19,7 +19,7 @@
 
 import java.lang.reflect.Modifier;
 
-import org.apache.drill.shaded.guava.com.google.common.annotations.VisibleForTesting;
+import com.google.common.annotations.VisibleForTesting;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

diff --git a/contrib/storage-hbase/pom.xml b/contrib/storage-hbase/pom.xml
@@ -164,9 +164,7 @@
     <profile>
       <id>default-hadoop</id>
       <activation>
-        <property>
-          <name>!alt-hadoop</name>
-        </property>
+        <activeByDefault>true</activeByDefault>
       </activation>
       <dependencies>
         <dependency>

diff --git a/distribution/pom.xml b/distribution/pom.xml
@@ -505,9 +505,7 @@
     <profile>
       <id>default-hadoop</id>
       <activation>
-        <property>
-          <name>!alt-hadoop</name>
-        </property>
+        <activeByDefault>true</activeByDefault>
       </activation>
       <build>
         <plugins>

diff --git a/exec/java-exec/pom.xml b/exec/java-exec/pom.xml
@@ -663,9 +663,7 @@
     <profile>
       <id>default-hadoop</id>
       <activation>
-        <property>
-          <name>!alt-hadoop</name>
-        </property>
+        <activeByDefault>true</activeByDefault>
       </activation>
     </profile>
     <profile>

diff --git a/exec/java-exec/src/test/resources/drill-udf/pom.xml b/exec/java-exec/src/test/resources/drill-udf/pom.xml
@@ -60,7 +60,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.8.0</version>
+        <version>3.11.0</version>
         <configuration>
           <includes>
             <include>${include.files}</include>

diff --git a/pom.xml b/pom.xml
@@ -819,7 +819,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-compiler-plugin</artifactId>
-          <version>3.8.1</version>
+          <version>3.11.0</version>
         </plugin>
         <plugin>
           <artifactId>maven-enforcer-plugin</artifactId>
@@ -2072,9 +2072,7 @@
     <profile>
       <id>default-hadoop</id>
       <activation>
-        <property>
-          <name>!alt-hadoop</name>
-        </property>
+        <activeByDefault>true</activeByDefault>
       </activation>
       <dependencyManagement>
         <dependencies>
@@ -3884,13 +3882,9 @@
     </profile>
     <profile>
       <id>hadoop-2</id>
-      <activation>
-        <property>
-          <name>hadoop-2</name>
-        </property>
-      </activation>
       <properties>
         <hadoop.version>2.10.2</hadoop.version>
+        <alt-hadoop>hadoop-2</alt-hadoop>
       </properties>
       <dependencyManagement>
         <dependencies>