-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][nereids] fix split count distinct for null can't join #46563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32579 ms
|
TPC-DS: Total hot run time: 189590 ms
|
ClickBench: Total hot run time: 31.65 s
|
morrySnow
previously approved these changes
Jan 7, 2025
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Jan 7, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
feiniaofeiafei
approved these changes
Jan 7, 2025
run p0 |
1 similar comment
run p0 |
run buildall |
run p0 |
TPC-H: Total hot run time: 32821 ms
|
TPC-DS: Total hot run time: 197363 ms
|
ClickBench: Total hot run time: 31.69 s
|
run p0 |
1 similar comment
run p0 |
run buildall |
TPC-H: Total hot run time: 32872 ms
|
TPC-DS: Total hot run time: 187911 ms
|
ClickBench: Total hot run time: 31.62 s
|
run p0 |
1 similar comment
run p0 |
run p0 |
7 similar comments
run p0 |
run p0 |
run p0 |
run p0 |
run p0 |
run p0 |
run p0 |
run buildall |
TPC-H: Total hot run time: 32697 ms
|
TPC-DS: Total hot run time: 187378 ms
|
ClickBench: Total hot run time: 31.6 s
|
morrySnow
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
related pr: #45209
If split cout distinct and group by are used, inner join will be used to link the results, but if the group by column has a null value, inner join will not be linked, so we use
NullSafeEqual
as the link conditiondetail sedd regression test cases
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)