Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](binlog) Add table type to getMeta method #45942

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Dec 25, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 25, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32653 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7b5ac08ebcae5c5340429c42daafebc895b7f208, data reload: false

------ Round 1 ----------------------------------
q1	17578	6184	6035	6035
q2	2053	297	163	163
q3	10515	1274	728	728
q4	10229	885	429	429
q5	7970	2216	1983	1983
q6	212	186	147	147
q7	918	749	607	607
q8	9248	1382	1141	1141
q9	5227	5038	4944	4944
q10	6776	2334	1870	1870
q11	482	275	259	259
q12	353	360	218	218
q13	17754	3670	3032	3032
q14	246	235	210	210
q15	577	509	499	499
q16	626	614	588	588
q17	563	850	322	322
q18	7153	6555	6436	6436
q19	2083	987	564	564
q20	304	312	184	184
q21	2822	2162	1988	1988
q22	363	335	306	306
Total cold run time: 104052 ms
Total hot run time: 32653 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6387	6218	6248	6218
q2	243	324	235	235
q3	2259	2711	2334	2334
q4	1415	1857	1396	1396
q5	4380	4770	4877	4770
q6	193	178	144	144
q7	2068	1968	1847	1847
q8	2678	2813	2754	2754
q9	7385	7337	7369	7337
q10	3106	3387	2778	2778
q11	584	498	486	486
q12	671	764	668	668
q13	3382	3791	3111	3111
q14	278	297	284	284
q15	585	539	509	509
q16	639	705	651	651
q17	1242	1753	1245	1245
q18	7771	7539	7347	7347
q19	853	1165	1138	1138
q20	1973	2058	1875	1875
q21	5680	5343	4944	4944
q22	616	638	625	625
Total cold run time: 54388 ms
Total hot run time: 52696 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196422 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7b5ac08ebcae5c5340429c42daafebc895b7f208, data reload: false

query1	1322	935	901	901
query2	6332	2331	2185	2185
query3	11028	4782	4824	4782
query4	33058	23845	23801	23801
query5	3728	619	460	460
query6	274	197	196	196
query7	3991	495	310	310
query8	303	253	234	234
query9	9325	2768	2756	2756
query10	483	309	247	247
query11	17935	15431	15106	15106
query12	157	108	105	105
query13	1576	559	431	431
query14	9819	6941	7655	6941
query15	276	226	184	184
query16	8478	646	460	460
query17	1618	816	599	599
query18	2096	440	337	337
query19	237	188	165	165
query20	118	118	110	110
query21	202	135	118	118
query22	4631	4759	4417	4417
query23	35443	33560	33532	33532
query24	6502	2280	2309	2280
query25	467	463	387	387
query26	722	250	161	161
query27	2102	472	327	327
query28	5649	2567	2483	2483
query29	546	545	424	424
query30	206	189	147	147
query31	986	912	853	853
query32	85	56	60	56
query33	471	368	302	302
query34	821	879	521	521
query35	865	844	795	795
query36	1046	1062	980	980
query37	115	93	74	74
query38	4239	4199	4220	4199
query39	1571	1457	1453	1453
query40	206	115	102	102
query41	44	42	44	42
query42	114	105	106	105
query43	537	524	488	488
query44	1330	827	820	820
query45	192	178	171	171
query46	896	1060	650	650
query47	2031	1969	1936	1936
query48	373	408	326	326
query49	720	482	402	402
query50	653	676	397	397
query51	7459	7291	7081	7081
query52	105	102	92	92
query53	228	266	185	185
query54	480	485	408	408
query55	80	89	80	80
query56	257	253	265	253
query57	1257	1244	1182	1182
query58	237	233	230	230
query59	3254	3265	3010	3010
query60	276	268	244	244
query61	104	107	110	107
query62	893	806	766	766
query63	233	194	195	194
query64	3333	1006	662	662
query65	3402	3275	3302	3275
query66	796	420	313	313
query67	16681	16057	15489	15489
query68	10496	771	527	527
query69	490	288	253	253
query70	1296	1128	1084	1084
query71	438	341	272	272
query72	5874	3860	3601	3601
query73	2293	758	356	356
query74	10267	9380	9058	9058
query75	4596	3155	2681	2681
query76	5740	1194	792	792
query77	1006	363	286	286
query78	10141	10303	9352	9352
query79	4652	893	602	602
query80	685	519	442	442
query81	480	283	222	222
query82	211	145	127	127
query83	196	156	140	140
query84	289	92	66	66
query85	752	344	320	320
query86	350	312	284	284
query87	4538	4617	4536	4536
query88	4069	2241	2256	2241
query89	439	328	290	290
query90	2087	194	190	190
query91	135	134	106	106
query92	66	55	50	50
query93	3377	897	547	547
query94	677	387	296	296
query95	329	270	252	252
query96	485	621	281	281
query97	2780	2816	2712	2712
query98	217	201	201	201
query99	1565	1566	1426	1426
Total cold run time: 306010 ms
Total hot run time: 196422 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.64 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7b5ac08ebcae5c5340429c42daafebc895b7f208, data reload: false

query1	0.03	0.03	0.03
query2	0.10	0.05	0.05
query3	0.23	0.06	0.07
query4	1.61	0.09	0.09
query5	0.43	0.42	0.42
query6	1.15	0.68	0.65
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.56	0.49	0.50
query10	0.55	0.58	0.55
query11	0.17	0.12	0.12
query12	0.16	0.13	0.13
query13	0.61	0.60	0.60
query14	2.71	2.72	2.84
query15	0.92	0.84	0.83
query16	0.37	0.38	0.37
query17	1.07	1.08	1.05
query18	0.18	0.19	0.18
query19	1.97	1.83	2.06
query20	0.02	0.01	0.01
query21	15.42	0.94	0.66
query22	0.78	0.77	0.71
query23	14.97	1.55	0.70
query24	2.22	0.38	0.24
query25	0.15	0.09	0.09
query26	0.29	0.19	0.18
query27	0.09	0.09	0.08
query28	13.47	1.80	1.13
query29	12.68	4.06	3.38
query30	0.25	0.08	0.05
query31	2.81	0.60	0.39
query32	3.22	0.57	0.48
query33	3.15	3.10	3.07
query34	16.68	5.18	4.53
query35	4.58	4.58	4.58
query36	0.63	0.49	0.52
query37	0.20	0.18	0.15
query38	0.16	0.15	0.16
query39	0.06	0.05	0.05
query40	0.18	0.14	0.14
query41	0.09	0.05	0.05
query42	0.07	0.05	0.05
query43	0.05	0.05	0.05
Total cold run time: 105.11 s
Total hot run time: 31.64 s

@w41ter w41ter merged commit e24e6d1 into apache:master Dec 26, 2024
26 of 28 checks passed
@w41ter w41ter deleted the add_table_type branch December 26, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.x reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants