-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](nerieds) month, day, hour, minute, second, day_of_year, day_of_month, week_of_year implement monotonic #45928
[enhance](nerieds) month, day, hour, minute, second, day_of_year, day_of_month, week_of_year implement monotonic #45928
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
ee2242f
to
b83f511
Compare
run buildall |
6b3811f
to
46efea6
Compare
run buildall |
TPC-H: Total hot run time: 32317 ms
|
TPC-DS: Total hot run time: 197854 ms
|
ClickBench: Total hot run time: 31.28 s
|
1e2a845
to
1ee003d
Compare
run buildall |
TPC-H: Total hot run time: 32491 ms
|
TPC-DS: Total hot run time: 189928 ms
|
ClickBench: Total hot run time: 30.84 s
|
run p0 |
run feut |
5c185ed
to
bb6fccd
Compare
run buildall |
TPC-H: Total hot run time: 32830 ms
|
TPC-DS: Total hot run time: 191870 ms
|
ClickBench: Total hot run time: 31.76 s
|
...rc/main/java/org/apache/doris/nereids/rules/expression/rules/OneRangePartitionEvaluator.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Cast.java
Outdated
Show resolved
Hide resolved
bb6fccd
to
0d61f9b
Compare
run buildall |
dc0cfb2
to
e108b19
Compare
run buildall |
TPC-H: Total hot run time: 32669 ms
|
TPC-DS: Total hot run time: 197217 ms
|
} | ||
|
||
@Override | ||
public boolean isMonotonic(Literal lower, Literal upper) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add consideration here
import org.apache.doris.nereids.trees.expressions.literal.BigIntLiteral; | ||
import org.apache.doris.nereids.trees.expressions.literal.Literal; | ||
|
||
/** monotonicity for from_xx */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from_xx => from_{xx}second ?
@@ -41,7 +42,7 @@ | |||
*/ | |||
public class WeeksAdd extends ScalarFunction | |||
implements BinaryExpression, ExplicitlyCastableSignature, | |||
ComputeSignatureForDateArithmetic, PropagateNullableOnDateLikeV2Args { | |||
ComputeSignatureForDateArithmetic, PropagateNullableOnDateLikeV2Args, DateAddSubMonotonic { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider more strict DateAddSubMonotonic with non-literal child-0 definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the first child is a constant, it will not affect the calculation of partition pruning. Consider the date_trunc('2024-01-01', 'day') function. If constant folding is turned on, the calculation logic of partition pruning will not be entered; if constant folding is turned off, the range returned by '2024-01-01' to the upper-level expression is empty. In this case, the range calculation will not be performed on this function, and the wrong partition pruning result will not be calculated.
07d0a95
to
440cd91
Compare
run buildall |
TPC-H: Total hot run time: 32674 ms
|
TPC-DS: Total hot run time: 196680 ms
|
ClickBench: Total hot run time: 30.87 s
|
run p0 |
run cloud_p0 |
PR approved by anyone and no changes requested. |
run cloud_p0 |
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)