Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](variant) disable column name with dot character for variant type #45927

Merged
merged 1 commit into from
Dec 26, 2024
Merged

[fix](variant) disable column name with dot character for variant type #45927

merged 1 commit into from
Dec 26, 2024
+40 −0

Conversation

cambyzju
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #44882

Variant type column named with '.' character make be crashed, here disable it temporarily.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 25, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@cambyzju
Copy link
Contributor Author

run buildall

eldenmoon
eldenmoon approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32742 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1e82a487bdceb6b8d2011dfe693991808244f637, data reload: false

------ Round 1 ----------------------------------
q1	17590	6142	6068	6068
q2	2052	289	171	171
q3	10430	1224	749	749
q4	10210	852	437	437
q5	7571	2168	1950	1950
q6	207	181	148	148
q7	892	757	604	604
q8	9239	1349	1118	1118
q9	5119	4877	4927	4877
q10	6740	2304	1878	1878
q11	478	283	258	258
q12	355	364	221	221
q13	17809	3640	2971	2971
q14	246	228	205	205
q15	573	511	507	507
q16	625	618	597	597
q17	573	857	340	340
q18	7134	6697	6548	6548
q19	1554	971	581	581
q20	312	337	194	194
q21	2896	2235	1993	1993
q22	360	347	327	327
Total cold run time: 102965 ms
Total hot run time: 32742 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6328	6251	6248	6248
q2	229	327	237	237
q3	2256	2664	2316	2316
q4	1380	1853	1373	1373
q5	4328	4707	4810	4707
q6	186	182	147	147
q7	2053	2010	1795	1795
q8	2609	2777	2678	2678
q9	7304	7285	7308	7285
q10	3077	3377	2794	2794
q11	567	515	500	500
q12	654	794	656	656
q13	3357	3740	3162	3162
q14	281	316	288	288
q15	587	512	507	507
q16	649	698	659	659
q17	1216	1736	1280	1280
q18	7669	7481	7459	7459
q19	829	1086	1137	1086
q20	1983	2056	1963	1963
q21	5749	5357	4999	4999
q22	607	620	593	593
Total cold run time: 53898 ms
Total hot run time: 52732 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197414 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1e82a487bdceb6b8d2011dfe693991808244f637, data reload: false

query1	1312	966	928	928
query2	6374	2225	2266	2225
query3	11073	4699	4709	4699
query4	32719	23713	23548	23548
query5	3716	615	464	464
query6	278	202	190	190
query7	3988	491	317	317
query8	308	246	241	241
query9	9347	2732	2731	2731
query10	452	313	244	244
query11	17838	15493	15516	15493
query12	168	102	102	102
query13	1572	512	404	404
query14	11145	7307	7395	7307
query15	262	202	190	190
query16	7955	645	512	512
query17	1541	790	630	630
query18	2145	437	312	312
query19	210	190	154	154
query20	115	129	117	117
query21	212	120	103	103
query22	4573	4730	4552	4552
query23	34281	33566	33429	33429
query24	6277	2249	2322	2249
query25	471	467	383	383
query26	830	273	154	154
query27	2091	476	339	339
query28	5565	2509	2463	2463
query29	614	550	409	409
query30	212	186	151	151
query31	956	877	841	841
query32	77	64	57	57
query33	467	350	280	280
query34	746	883	514	514
query35	821	875	772	772
query36	1029	1096	985	985
query37	117	100	77	77
query38	4280	4156	4318	4156
query39	1491	1510	1448	1448
query40	213	113	101	101
query41	44	42	44	42
query42	126	104	103	103
query43	520	527	500	500
query44	1343	819	838	819
query45	181	176	177	176
query46	877	1083	689	689
query47	2018	1990	1985	1985
query48	387	420	321	321
query49	698	485	376	376
query50	665	669	402	402
query51	7142	7281	7184	7184
query52	102	100	93	93
query53	224	259	185	185
query54	481	489	419	419
query55	76	78	76	76
query56	247	268	250	250
query57	1290	1222	1185	1185
query58	236	226	225	225
query59	3101	3240	3182	3182
query60	269	263	265	263
query61	146	135	134	134
query62	863	816	750	750
query63	226	193	190	190
query64	3590	1034	687	687
query65	3349	3259	3281	3259
query66	778	403	312	312
query67	16585	15864	15598	15598
query68	9840	764	519	519
query69	478	293	252	252
query70	1154	1178	1096	1096
query71	439	278	248	248
query72	6233	3967	3880	3880
query73	659	747	362	362
query74	10467	9374	9023	9023
query75	4589	3164	2666	2666
query76	5179	1206	816	816
query77	941	371	292	292
query78	10294	10350	9437	9437
query79	2482	888	599	599
query80	653	521	420	420
query81	492	282	230	230
query82	339	150	118	118
query83	185	160	141	141
query84	286	81	68	68
query85	737	366	302	302
query86	355	315	299	299
query87	4415	4440	4453	4440
query88	3436	2246	2247	2246
query89	420	333	288	288
query90	2034	190	188	188
query91	131	125	105	105
query92	66	55	52	52
query93	976	859	543	543
query94	659	396	277	277
query95	332	263	250	250
query96	497	610	283	283
query97	2712	2842	2696	2696
query98	222	211	198	198
query99	1803	1565	1404	1404
Total cold run time: 296910 ms
Total hot run time: 197414 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.65 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1e82a487bdceb6b8d2011dfe693991808244f637, data reload: false

query1	0.03	0.03	0.05
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.61	0.11	0.10
query5	0.40	0.40	0.41
query6	1.14	0.66	0.64
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.49
query10	0.56	0.56	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.84	2.73	2.80
query15	0.89	0.83	0.82
query16	0.36	0.38	0.38
query17	1.01	0.98	1.05
query18	0.23	0.22	0.22
query19	1.84	1.78	1.93
query20	0.01	0.01	0.01
query21	15.37	0.94	0.58
query22	0.77	0.79	0.62
query23	15.27	1.44	0.50
query24	3.76	0.40	1.31
query25	0.14	0.22	0.09
query26	0.30	0.17	0.14
query27	0.07	0.05	0.05
query28	13.39	1.52	1.04
query29	12.61	3.94	3.28
query30	0.25	0.08	0.06
query31	2.82	0.59	0.38
query32	3.22	0.54	0.47
query33	3.13	3.13	3.11
query34	16.90	5.12	4.53
query35	4.51	4.53	4.56
query36	0.65	0.51	0.48
query37	0.10	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.42 s
Total hot run time: 30.65 s

lide-reed
lide-reed approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed lide-reed merged commit 4036b67 into apache:master Dec 26, 2024
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 26, 2024
@cambyzju
[fix](variant) disable column name with dot character for variant type (
f4e6061 
#45927)

Variant type column named with '.' character make be crashed, here
disable it temporarily.
@github-actions github-actions bot mentioned this pull request Dec 26, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 26, 2024
@cambyzju
[fix](variant) disable column name with dot character for variant type (
cb41cd6 
#45927)

Variant type column named with '.' character make be crashed, here
disable it temporarily.
@github-actions github-actions bot mentioned this pull request Dec 26, 2024
Merged
eldenmoon pushed a commit that referenced this pull request Dec 27, 2024
@github-actions @cambyzju
branch-3.0: [fix](variant) disable column name with dot character for…
06b7485 
… variant type #45927 (#45990)

Cherry-picked from #45927

Co-authored-by: camby <[email protected]>
eldenmoon pushed a commit that referenced this pull request Dec 27, 2024
@github-actions @cambyzju
branch-2.1: [fix](variant) disable column name with dot character for…
6cee955 
… variant type #45927 (#45992)

Cherry-picked from #45927

Co-authored-by: camby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@xy720 xy720 xy720 approved these changes

@lide-reed lide-reed lide-reed approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Be crash because of variant type
6 participants
@cambyzju @Thearas @doris-robot @lide-reed @xy720 @eldenmoon