-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](nereids) fix compare with date like overflow #45868
Merged
starocean999
merged 3 commits into
apache:master
from
yujun777:fix-compare-with-date-like-overflow
Dec 25, 2024
Merged
[fix](nereids) fix compare with date like overflow #45868
starocean999
merged 3 commits into
apache:master
from
yujun777:fix-compare-with-date-like-overflow
Dec 25, 2024
+87
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32813 ms
|
TPC-DS: Total hot run time: 188969 ms
|
ClickBench: Total hot run time: 31.56 s
|
run buildall |
morrySnow
approved these changes
Dec 25, 2024
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Dec 25, 2024
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 32926 ms
|
TPC-DS: Total hot run time: 191774 ms
|
ClickBench: Total hot run time: 31.91 s
|
starocean999
approved these changes
Dec 25, 2024
This was referenced Dec 25, 2024
morrySnow
pushed a commit
that referenced
this pull request
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.x
dev/2.1.x-conflict
dev/3.0.4-merged
p0_b
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
fix compare date like overflow, for example:
there two rewritten exprs will met an overflow case.
to fix this, when met overflow case, we don't rewrite the expression.
but what's more, these above two expression both can rewrite to 'TRUE'
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)