Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pick](branch-2.1) pick #44092 #45836

Merged
merged 4 commits into from
Dec 25, 2024

Conversation

xinyiZzz
Copy link
Contributor

What problem does this PR solve?

fix Fix init segment map check memory exceeds limit #44092

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…#44092)

### What problem does this PR solve?

Problem Summary:

`RowIdConversion::init_segment_map` may use a lot of memory in
compaction. however, this part of memory is not controlled, the process
may OOM crash.

If process has less than 10M available memory before generating
`rowid_map` for each segment in `init_segment_map`, it will terminate.


![image](https://github.com/user-attachments/assets/652fadc9-bca0-4edd-a03e-04f2546cdf76)
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.47% (9572/26247)
Line Coverage: 27.93% (78681/281741)
Region Coverage: 26.59% (40378/151839)
Branch Coverage: 23.35% (20449/87586)
Coverage Report: http://coverage.selectdb-in.cc/coverage/745dff97de117ab3a84e5bd111281deb74477859_745dff97de117ab3a84e5bd111281deb74477859/report/index.html

@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.49% (9578/26247)
Line Coverage: 27.94% (78713/281744)
Region Coverage: 26.62% (40414/151842)
Branch Coverage: 23.37% (20466/87588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0eaf890cf6cfefef26fe3ee00afcb0daad7394ef_0eaf890cf6cfefef26fe3ee00afcb0daad7394ef/report/index.html

@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9576/26247)
Line Coverage: 27.94% (78724/281744)
Region Coverage: 26.61% (40405/151842)
Branch Coverage: 23.36% (20462/87588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/88fb6838b167bbdb09d541ea9b46314ac6608b8a_88fb6838b167bbdb09d541ea9b46314ac6608b8a/report/index.html

@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.39% (9540/26217)
Line Coverage: 27.90% (78590/281689)
Region Coverage: 26.57% (40336/151814)
Branch Coverage: 23.33% (20432/87568)
Coverage Report: http://coverage.selectdb-in.cc/coverage/348445eacb5937b71f298d185055e0b8b538ea79_348445eacb5937b71f298d185055e0b8b538ea79/report/index.html

@yiguolei yiguolei merged commit 1cf6986 into apache:branch-2.1 Dec 25, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants