Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test](regression-test) use unified trigger_and_wait_compaction method #45761

Merged
merged 20 commits into from
Dec 24, 2024

Conversation

py023
Copy link
Contributor

@py023 py023 commented Dec 22, 2024

What problem does this PR solve?

Issue Number: close #45591
Related PR: #38836

Problem Summary: Previously many regression cases use their own private functions to trigger compaction, results in a bunch of error-prone copy-pasted code. This PR introduces a unified method to trigger and wait compaction finished. Hopefully new cases won't need to write their own compaction method in the future.

Unsolved problem: Several cases(~20) have more dedicated actions to check compaction result, I didn't modify those cases in this PR, to avoid unexpected case behavior change. It's better to handle those cases in another PR, as it takes more times and this PR is already a huge change set.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 22, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@py023
Copy link
Contributor Author

py023 commented Dec 22, 2024

run buildall

@py023
Copy link
Contributor Author

py023 commented Dec 23, 2024

run p0
run cloud_p0

@py023
Copy link
Contributor Author

py023 commented Dec 23, 2024

run p0
run cloud_p0

@py023
Copy link
Contributor Author

py023 commented Dec 23, 2024

run buildall

@py023
Copy link
Contributor Author

py023 commented Dec 23, 2024

run p0
run cloud_p0

@hello-stephen
Copy link
Contributor

run p0

@hello-stephen
Copy link
Contributor

run cloud_p0

@py023 py023 force-pushed the 1219-compaction-check branch from 47b35e7 to 217bcde Compare December 23, 2024 09:53
@py023
Copy link
Contributor Author

py023 commented Dec 23, 2024

run cloud_p0

@py023
Copy link
Contributor Author

py023 commented Dec 23, 2024

run p0

@py023
Copy link
Contributor Author

py023 commented Dec 23, 2024

run buildall

1 similar comment
@py023
Copy link
Contributor Author

py023 commented Dec 24, 2024

run buildall

@py023 py023 force-pushed the 1219-compaction-check branch from 84022f3 to 7eed0d5 Compare December 24, 2024 02:59
@py023
Copy link
Contributor Author

py023 commented Dec 24, 2024

run buildall

@py023
Copy link
Contributor Author

py023 commented Dec 24, 2024

run buildall

@py023
Copy link
Contributor Author

py023 commented Dec 24, 2024

run buildall

@py023 py023 marked this pull request as ready for review December 24, 2024 09:15
@shuke987
Copy link
Collaborator

run buildall

@py023
Copy link
Contributor Author

py023 commented Dec 24, 2024

run buildall

Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 24, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect usage of Awaitility.await() in test case
7 participants