Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](recycler) Fix CountdownEvent error and hang #45760

Merged
merged 4 commits into from
Dec 24, 2024
Merged

[fix](recycler) Fix CountdownEvent error and hang #45760

merged 4 commits into from
Dec 24, 2024
+118 −4

Conversation

Yukang-Lian
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Fix CountdownEvent error "Invoking add_count() after wait() was invoked"

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 21, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@dataroaring dataroaring added usercase Important user case type label dev/3.0.x labels Dec 23, 2024
@Yukang-Lian
Copy link
Collaborator Author

run buildall

@Yukang-Lian
Copy link
Collaborator Author

run buildall

gavinchou
gavinchou approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@gavinchou gavinchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou changed the title [fix](recycler) Fix CountdownEvent error [fix](recycler) Fix CountdownEvent error "Invoking add_count() after wait() was invoked" Dec 23, 2024
@gavinchou gavinchou changed the title [fix](recycler) Fix CountdownEvent error "Invoking add_count() after wait() was invoked" [fix](recycler) Fix CountdownEvent error and hang-up Dec 23, 2024
@gavinchou gavinchou changed the title [fix](recycler) Fix CountdownEvent error and hang-up [fix](recycler) Fix CountdownEvent error and hang Dec 23, 2024
@gavinchou gavinchou added the p0_c label Dec 23, 2024
@Yukang-Lian
Copy link
Collaborator Author

run buildall

@w41ter w41ter merged commit e3b18b5 into apache:master Dec 24, 2024
28 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 24, 2024
@Yukang-Lian @gavinchou
[fix](recycler) Fix CountdownEvent error and hang (#45760)
7ad4af6 
Fix CountdownEvent error "Invoking add_count() after wait() was invoked"

---------

Co-authored-by: Gavin Chou <[email protected]>
@github-actions github-actions bot mentioned this pull request Dec 24, 2024
Merged
gavinchou added a commit that referenced this pull request Dec 24, 2024
@github-actions @Yukang-Lian @gavinchou
branch-3.0: [fix](recycler) Fix CountdownEvent error and hang #45760 (#…
bfd5966 
…45853)

Cherry-picked from #45760

Co-authored-by: abmdocrt <[email protected]>
Co-authored-by: Gavin Chou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobhan1 bobhan1 bobhan1 approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged p0_c reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yukang-Lian @Thearas @gavinchou @bobhan1 @w41ter @dataroaring