[fix](mtmv) Fix mv is deleted in nested mv causing query err and fix some test #45744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
seawinde
changed the title
|
run buildall |
TPC-H: Total hot run time: 39993 ms |
TPC-DS: Total hot run time: 195599 ms |
ClickBench: Total hot run time: 32.68 s |
|
run buildall |
zddr
reviewed
Dec 23, 2024
| @@ -130,6 +130,9 @@ suite("test_select_column_auth","p0,auth") { | |||
| sql """grant select_priv(sum_id) on ${dbName}.${mtmv_name} to ${user}""" | |||
| sql """grant select_priv(id) on ${dbName}.${tableName} to ${user}""" | |||
| connect(user, "${pwd}", context.config.jdbcUrl) { | |||
| logger.info("show grants;") | |||
| @@ -96,6 +96,10 @@ suite("mv_on_unique_table") { | |||
| AS | |||
| ${mv1} | |||
| """) | |||
|
|
|||
| def desc_all_mv1 = sql """desc lineitem_2_uniq all;""" | |||
| logger.info("desc mv1 is" + desc_all_mv1) | |||
There was a problem hiding this comment.
not need desc_all_mv1.toString()?
| @@ -115,7 +119,9 @@ suite("is_in_debug_mode") { | |||
| AS select * from orders where o_orderkey > 2; | |||
| """ | |||
| } catch (Exception e) { | |||
| Assert.assertTrue(e.getMessage().contains("because is in debug mode")) | |||
| def message = e.getMessage() | |||
| logger.info("test_create_mv3" + message) | |||
There was a problem hiding this comment.
suggest: logger.info("test_create_mv3: " + message)
TPC-H: Total hot run time: 39452 ms |
TPC-DS: Total hot run time: 196475 ms |
ClickBench: Total hot run time: 32.16 s |
|
run buildall |
morrySnow
approved these changes
Dec 23, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39863 ms |
TPC-DS: Total hot run time: 190372 ms |
ClickBench: Total hot run time: 32.62 s |
zddr
approved these changes
Dec 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 24, 2024
…some test (#45744) ### What problem does this PR solve? Related PR: #45045 Problem Summary: if mv2 sql contains mv1 as following, if drop mv_level_1, query mv2 directly would cause err, this fix this CREATE MATERIALIZED VIEW mv2 BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS SELECT * FROM mv_level_1;
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Dec 24, 2024
…some test (apache#45744) Related PR: apache#45045 Problem Summary: if mv2 sql contains mv1 as following, if drop mv_level_1, query mv2 directly would cause err, this fix this CREATE MATERIALIZED VIEW mv2 BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS SELECT * FROM mv_level_1;
yiguolei
pushed a commit
that referenced
this pull request
Dec 24, 2024
yiguolei
pushed a commit
that referenced
this pull request
Dec 24, 2024
…err and fix some test #45744 (#45843) Cherry-picked from #45744 Co-authored-by: seawinde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
if mv2 sql contains mv1 as following, if drop mv_level_1, query mv2 directly would cause err, this fix this
CREATE MATERIALIZED VIEW mv2 BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select * from mv_level_1;Issue Number: close #xxx
Related PR: #45045
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)