Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [fix](cloud) fix abort transaction in runningTxns list when show routine load #45629 #45721

Merged
merged 1 commit into from
Dec 26, 2024
Merged

branch-3.0: [fix](cloud) fix abort transaction in runningTxns list when show routine load #45629 #45721

merged 1 commit into from
Dec 26, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45629

@sollhui
[fix](cloud) fix abort transaction in runningTxns list when show rout…
6ed0ffc 
…ine load (#45629)

There are some abort transaction in running transaction list when
execute `Show routine load`:
```
statistic: {"receivedBytes":690347731,"runningTxns":[84983868539904,85435786230784,85005343163392,85437129268225,85454778056704,85435116123136,85025611246592,85437060583424,85434241746944,85415318736896,85465045433344,84985143969794,85004337471488,85415183878144,85415385197568,85424109151232,85004808868865,85005412474880,85025545732096,85414981022720,84984677082113,85436924459012],"errorRows":0,"committedTaskNum":211,"loadedRows":3612290,"loadRowsRate":195026,"abortedTaskNum":1,"errorRowsAfterResumed":0,"totalRows":3612290,"unselectedRows":0,"receivedBytesRate":37271770,"taskExecuteTimeMs":18522} 
```

When abort transaction to meta service, transaction info in
`abortTxnResponse `would be default value when abort transaction
failed.Then this logic will invalid for transaction id is default value:
```
this.jobStatistic.runningTxnIds.remove(txnState.getTransactionId());
```
@Thearas
Copy link
Contributor

Thearas commented Dec 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 20, 2024
@Thearas
Copy link
Contributor

Thearas commented Dec 20, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40283 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6ed0ffc149b5b2caa9d4a0ce78a88b06913d5496, data reload: false

------ Round 1 ----------------------------------
q1	17582	7309	7271	7271
q2	2076	172	161	161
q3	10897	1050	1164	1050
q4	10560	769	749	749
q5	7728	2728	2752	2728
q6	230	149	147	147
q7	948	625	598	598
q8	9566	1889	1933	1889
q9	7788	6394	6428	6394
q10	6988	2293	2319	2293
q11	450	254	258	254
q12	402	218	216	216
q13	17779	3001	2981	2981
q14	240	204	210	204
q15	560	503	516	503
q16	683	603	622	603
q17	951	507	528	507
q18	7307	6574	6512	6512
q19	4177	998	1056	998
q20	473	208	197	197
q21	3918	3092	3057	3057
q22	1118	971	976	971
Total cold run time: 112421 ms
Total hot run time: 40283 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7417	7249	7156	7156
q2	314	237	230	230
q3	3028	2848	2803	2803
q4	2022	1773	1740	1740
q5	5643	5824	5737	5737
q6	215	142	141	141
q7	2159	1758	1728	1728
q8	3362	3522	3405	3405
q9	8811	8823	8765	8765
q10	3525	3530	3485	3485
q11	597	505	497	497
q12	782	592	618	592
q13	16485	3147	3185	3147
q14	301	279	270	270
q15	579	517	532	517
q16	707	676	678	676
q17	1826	1636	1591	1591
q18	8319	7880	7437	7437
q19	1679	1541	1516	1516
q20	2060	1867	1853	1853
q21	5317	5250	5205	5205
q22	1135	981	1035	981
Total cold run time: 76283 ms
Total hot run time: 59472 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195433 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6ed0ffc149b5b2caa9d4a0ce78a88b06913d5496, data reload: false

query1	1291	938	924	924
query2	6252	2172	2159	2159
query3	10988	4192	4077	4077
query4	67064	29078	23436	23436
query5	5295	453	428	428
query6	458	167	166	166
query7	5657	309	305	305
query8	309	224	242	224
query9	9587	2682	2659	2659
query10	496	263	258	258
query11	17594	15292	15853	15292
query12	158	103	106	103
query13	1541	421	432	421
query14	10806	6442	6894	6442
query15	214	176	190	176
query16	7843	497	508	497
query17	1090	575	567	567
query18	1891	347	308	308
query19	245	156	158	156
query20	114	110	105	105
query21	73	45	43	43
query22	4709	4496	4281	4281
query23	34218	34359	34085	34085
query24	6132	2922	2915	2915
query25	552	419	425	419
query26	706	177	169	169
query27	1770	302	300	300
query28	4241	2531	2514	2514
query29	713	458	461	458
query30	241	165	159	159
query31	998	832	788	788
query32	66	56	57	56
query33	457	276	271	271
query34	912	490	494	490
query35	849	734	754	734
query36	1076	973	938	938
query37	118	69	69	69
query38	4051	3976	4023	3976
query39	1505	1470	1450	1450
query40	144	82	80	80
query41	47	47	49	47
query42	123	103	107	103
query43	532	514	502	502
query44	1161	788	794	788
query45	185	166	171	166
query46	1149	733	735	733
query47	2012	1890	1906	1890
query48	484	375	374	374
query49	726	371	372	371
query50	839	410	413	410
query51	7313	7162	7049	7049
query52	99	88	86	86
query53	258	180	188	180
query54	554	450	432	432
query55	74	76	75	75
query56	247	225	251	225
query57	1223	1096	1101	1096
query58	207	194	211	194
query59	3342	3103	2947	2947
query60	273	246	238	238
query61	105	107	100	100
query62	767	654	655	654
query63	215	189	198	189
query64	1722	650	619	619
query65	3254	3191	3142	3142
query66	645	291	308	291
query67	15810	15342	15353	15342
query68	5371	548	555	548
query69	426	251	252	251
query70	1173	1129	1061	1061
query71	390	250	248	248
query72	6544	3890	3991	3890
query73	767	335	346	335
query74	10074	8926	8973	8926
query75	3321	2592	2603	2592
query76	2387	1111	1077	1077
query77	515	262	264	262
query78	10795	9994	9732	9732
query79	5055	611	578	578
query80	1993	407	417	407
query81	552	242	238	238
query82	1048	123	120	120
query83	255	153	148	148
query84	300	88	73	73
query85	1364	310	314	310
query86	491	302	301	301
query87	4457	4350	4206	4206
query88	5007	2366	2412	2366
query89	426	289	291	289
query90	2107	191	184	184
query91	178	145	145	145
query92	75	48	48	48
query93	5263	535	517	517
query94	1035	281	293	281
query95	346	252	251	251
query96	627	283	277	277
query97	3355	3143	3157	3143
query98	220	197	197	197
query99	1697	1307	1291	1291
Total cold run time: 333404 ms
Total hot run time: 195433 ms

@dataroaring dataroaring merged commit 9f2097c into branch-3.0 Dec 26, 2024
19 of 21 checks passed
@github-actions github-actions bot deleted the auto-pick-45629-branch-3.0 branch December 26, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thearas @doris-robot @dataroaring @sollhui