Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](log) add more info in nereids timeout log #45705

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[opt](log) add more info in nereids timeout log #45705

merged 1 commit into from
Dec 23, 2024

Conversation

morningman
Copy link
Contributor

What problem does this PR solve?

Add elapsed time in log

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40089 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8bce27180f3f7ef3044dd046ca5df82f68e27dbd, data reload: false

------ Round 1 ----------------------------------
q1	17623	7506	7295	7295
q2	2048	178	166	166
q3	10641	1082	1182	1082
q4	10563	784	737	737
q5	7599	2697	2687	2687
q6	248	154	147	147
q7	990	626	596	596
q8	9251	1876	1863	1863
q9	6684	6430	6461	6430
q10	7011	2252	2325	2252
q11	470	263	258	258
q12	446	233	228	228
q13	18146	3134	3133	3133
q14	258	218	216	216
q15	562	525	508	508
q16	656	600	593	593
q17	983	569	498	498
q18	7484	6673	6701	6673
q19	1367	1045	941	941
q20	485	182	182	182
q21	4104	3286	3330	3286
q22	390	318	327	318
Total cold run time: 108009 ms
Total hot run time: 40089 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7299	7228	7237	7228
q2	330	228	232	228
q3	2927	2902	2943	2902
q4	1993	1835	1856	1835
q5	5654	5672	5627	5627
q6	233	145	149	145
q7	2270	1806	1805	1805
q8	3447	3562	3520	3520
q9	8865	9032	8980	8980
q10	3621	3562	3539	3539
q11	596	515	518	515
q12	837	614	608	608
q13	11914	3220	3122	3122
q14	325	268	287	268
q15	577	521	499	499
q16	693	649	639	639
q17	1862	1622	1596	1596
q18	8211	7884	7683	7683
q19	1779	1395	1564	1395
q20	2105	1889	1866	1866
q21	5683	5538	5565	5538
q22	693	626	591	591
Total cold run time: 71914 ms
Total hot run time: 60129 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198384 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8bce27180f3f7ef3044dd046ca5df82f68e27dbd, data reload: false

query1	1276	988	903	903
query2	6249	2505	2458	2458
query3	11100	4827	4726	4726
query4	32967	23561	23381	23381
query5	4286	456	459	456
query6	286	184	188	184
query7	3983	304	314	304
query8	306	245	243	243
query9	9527	2694	2679	2679
query10	478	266	261	261
query11	17923	15246	15219	15219
query12	157	103	100	100
query13	1557	420	413	413
query14	10244	7434	6987	6987
query15	252	196	192	192
query16	8117	477	492	477
query17	1628	587	612	587
query18	2150	320	312	312
query19	357	158	172	158
query20	129	114	108	108
query21	209	108	113	108
query22	4904	4486	4404	4404
query23	37652	35280	34340	34340
query24	10464	2648	2574	2574
query25	517	400	398	398
query26	729	170	156	156
query27	2385	335	331	331
query28	7514	2469	2443	2443
query29	681	421	412	412
query30	235	151	154	151
query31	1057	872	847	847
query32	97	56	56	56
query33	776	309	301	301
query34	1137	531	509	509
query35	897	782	798	782
query36	1114	959	974	959
query37	133	82	75	75
query38	4266	4218	4215	4215
query39	1512	1499	1468	1468
query40	242	104	106	104
query41	45	46	47	46
query42	120	103	105	103
query43	560	509	525	509
query44	1279	848	847	847
query45	187	176	171	171
query46	1213	725	737	725
query47	2058	1889	1934	1889
query48	431	336	320	320
query49	881	409	403	403
query50	862	418	398	398
query51	7413	7351	7311	7311
query52	107	102	93	93
query53	263	187	185	185
query54	1040	428	419	419
query55	81	84	83	83
query56	285	270	269	269
query57	1284	1174	1156	1156
query58	256	230	234	230
query59	3517	3267	3332	3267
query60	289	252	255	252
query61	112	106	123	106
query62	838	724	685	685
query63	226	191	195	191
query64	3900	691	709	691
query65	3305	3267	3313	3267
query66	730	304	317	304
query67	16484	15612	15590	15590
query68	5430	558	531	531
query69	482	267	316	267
query70	1228	1162	1141	1141
query71	483	244	250	244
query72	6709	4178	4105	4105
query73	804	364	373	364
query74	10009	9019	9065	9019
query75	3423	2627	2636	2627
query76	3798	1065	1083	1065
query77	735	279	265	265
query78	10264	9390	9545	9390
query79	2760	622	604	604
query80	1275	432	446	432
query81	504	232	238	232
query82	645	115	114	114
query83	195	143	148	143
query84	288	73	69	69
query85	1288	351	301	301
query86	399	273	273	273
query87	4550	4566	4478	4478
query88	3892	2249	2221	2221
query89	433	295	289	289
query90	1982	201	187	187
query91	140	108	104	104
query92	74	51	52	51
query93	3026	540	542	540
query94	694	294	297	294
query95	348	251	261	251
query96	624	290	284	284
query97	2869	2700	2696	2696
query98	217	198	203	198
query99	1652	1339	1314	1314
Total cold run time: 308479 ms
Total hot run time: 198384 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.81 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8bce27180f3f7ef3044dd046ca5df82f68e27dbd, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.08	0.08
query4	1.60	0.11	0.10
query5	0.41	0.38	0.40
query6	1.17	0.66	0.65
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.58	0.51	0.53
query10	0.55	0.58	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.12
query13	0.60	0.61	0.60
query14	2.73	2.72	2.71
query15	0.89	0.82	0.81
query16	0.39	0.38	0.40
query17	1.04	1.05	1.06
query18	0.23	0.22	0.21
query19	1.93	1.79	2.02
query20	0.01	0.02	0.01
query21	15.36	0.58	0.58
query22	2.68	2.20	2.33
query23	17.01	0.90	0.93
query24	3.10	1.08	0.60
query25	0.22	0.09	0.05
query26	0.43	0.13	0.13
query27	0.05	0.04	0.06
query28	10.90	1.10	1.09
query29	12.60	3.26	3.24
query30	0.25	0.07	0.06
query31	2.86	0.41	0.39
query32	3.24	0.45	0.45
query33	3.05	3.11	3.16
query34	17.01	4.53	4.56
query35	4.55	4.49	4.54
query36	0.68	0.48	0.47
query37	0.10	0.07	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 107.35 s
Total hot run time: 32.81 s

@morningman morningman merged commit cccc9bb into apache:master Dec 23, 2024
26 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 23, 2024
@morningman
[opt](log) add more info in nereids timeout log (#45705)
1c78da4 
### What problem does this PR solve?

Add elapsed time in log
@github-actions github-actions bot mentioned this pull request Dec 23, 2024
Merged
morningman added a commit that referenced this pull request Dec 23, 2024
@github-actions @morningman
branch-3.0: [opt](log) add more info in nereids timeout log #45705 (#…
451d342 
…45786)

Cherry-picked from #45705

Co-authored-by: Mingyu Chen (Rayner) <[email protected]>
morningman added a commit to morningman/doris that referenced this pull request Dec 23, 2024
@morningman
branch-2.1: [opt](log) add more info in nereids timeout log apache#45705
493873a
@morningman morningman mentioned this pull request Dec 23, 2024
Merged
morningman added a commit that referenced this pull request Dec 23, 2024
@morningman
branch-2.1: [opt](log) add more info in nereids timeout log #45705 (#…
901b932 
…45793)

cherry-pick #45705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morningman @Thearas @doris-robot @CalvinKirs @morrySnow