-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement](tablet-meta) Avoid be coredump due to potential race condition when updating tablet cumu point #45643
Conversation
…ndition when updating tablet cumu point
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39775 ms
|
TPC-DS: Total hot run time: 196257 ms
|
ClickBench: Total hot run time: 32.97 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…ndition when updating tablet cumu point (#45643) Currently, when setting tablet's cumu point, aseert fail will happend if new point is less than local value, resulting BE coredump. This could happend when race condition happend: 1. thread A try to sync rowset 2. thread A fetch cumu point from ms 3. thread B update cumu point(like sc/compaction),commit to ms after 2. and set be tablet cumu point before 4. 4. thread A try to set cumu point seen before and meet the assertion, coredump.
…tial race condition when updating tablet cumu point #45643 (#45785) Cherry-picked from #45643 Co-authored-by: Siyang Tang <[email protected]>
What problem does this PR solve?
Problem Summary:
Currently, when setting tablet's cumu point, aseert fail will happend if new point is less than local value, resulting BE coredump.
This could happend when race condition happend:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)