-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch-2.1: [bug](function) fix first/last value return error with ignore null #44996 #45345
Conversation
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
run buildall |
…44996) ### What problem does this PR solve? Problem Summary: needs another prs of FE: #45065 #45264 1. the first value even if have set value, should not return directly, need check it whether need arg_ignore_null, as maybe it's NULL 2. the last_value if need arg_ignore_null and not set value, should find in while loop, if find could return directly, not find check iff has any value before ### Release note fix first_value/last_value return error with ignore null param is true
ba844bb
to
6b0a45d
Compare
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
run buildall |
TeamCity be ut coverage result: |
Cherry-picked from #44996