Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-2.1: [bug](function) fix first/last value return error with ignore null #44996 #45345

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #44996

@zhangstar333
Copy link
Contributor

run buildall

Copy link
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9569/26232)
Line Coverage: 27.92% (78634/281654)
Region Coverage: 26.60% (40385/151836)
Branch Coverage: 23.35% (20451/87594)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ba844bb4e2e9fd70606c3d18d7ff24a3fdce8109_ba844bb4e2e9fd70606c3d18d7ff24a3fdce8109/report/index.html

@zhangstar333
Copy link
Contributor

run buildall

…44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: #45065
#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
@yiguolei yiguolei force-pushed the auto-pick-44996-branch-2.1 branch from ba844bb to 6b0a45d Compare December 16, 2024 09:11
@yiguolei
Copy link
Contributor

run buildall

Copy link
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9569/26232)
Line Coverage: 27.93% (78666/281654)
Region Coverage: 26.60% (40386/151836)
Branch Coverage: 23.35% (20454/87594)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6b0a45da1f5dbb1040c93ce1d603c61b8b2f3135_6b0a45da1f5dbb1040c93ce1d603c61b8b2f3135/report/index.html

@zhangstar333
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.47% (9568/26232)
Line Coverage: 27.93% (78667/281654)
Region Coverage: 26.59% (40377/151836)
Branch Coverage: 23.35% (20457/87594)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6b0a45da1f5dbb1040c93ce1d603c61b8b2f3135_6b0a45da1f5dbb1040c93ce1d603c61b8b2f3135/report/index.html

@yiguolei yiguolei closed this Dec 17, 2024
@dataroaring dataroaring deleted the auto-pick-44996-branch-2.1 branch December 27, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants