Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-2.1: [fix](nereids) not rewrite first_value when first_value ignore nulls #45065 #45236

Merged
merged 1 commit into from
Dec 11, 2024
Merged

branch-2.1: [fix](nereids) not rewrite first_value when first_value ignore nulls #45065 #45236

merged 1 commit into from
Dec 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45065

@feiniaofeiafei
[fix](nereids) not rewrite first_value when first_value ignore nulls (#…
8d86b40 
…45065)

this pr fix 2 things:
1.when first_value/last_value second parameter is true, which means
ignore nulls, fe should not do some rewrite.
2.adding check that first_value/last_value second parameter must be true
or false.

Related PR: #44996 #27623
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 10, 2024
@doris-robot
Copy link

run buildall

@yiguolei yiguolei merged commit cbab6f5 into branch-2.1 Dec 11, 2024
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-45065-branch-2.1 branch December 11, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doris-robot @yiguolei @dataroaring @feiniaofeiafei