-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](vault) avoid duplicated name and id #45158
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
@@ -1085,11 +1119,11 @@ void MetaServiceImpl::alter_storage_vault(google::protobuf::RpcController* contr | |||
} | |||
case AlterObjStoreInfoRequest::ALTER_S3_VAULT: { | |||
alter_s3_storage_vault(instance, std::move(txn), request->vault(), code, msg); | |||
return; | |||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ret = alter_s3_storage_vault()
if ret != 0 should not break => nothing should be changed to isntancePB
run buildall |
I will fix the problem with https://github.com/apache/doris/pull/45685/files |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)