Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opt](function) Speed up function string and add regression #45062

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

zclllyybb
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #44919

Problem Summary:

Add the missing testcase for the bug which was fixed in the PR mentioned above. and optimized its performance

before:

mysql> select count(space(100000000)) from double_ranges;
+-------------------------+
| count(space(100000000)) |
+-------------------------+
|                50000000 |
+-------------------------+
1 row in set (0.88 sec)

now:

mysql> select count(space(100000000)) from double_ranges;
+-------------------------+
| count(space(100000000)) |
+-------------------------+
|                50000000 |
+-------------------------+
1 row in set (0.66 sec)

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2024
@BiteTheDDDDt BiteTheDDDDt added dev/3.0.x and removed approved Indicates a PR has been approved by one committer. labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR approved by at least one committer and no changes requested.

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.48% (10007/26003)
Line Coverage: 29.52% (83913/284304)
Region Coverage: 28.61% (43117/150693)
Branch Coverage: 25.21% (21917/86954)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3b3a413562d672490bb32e2ab8917178ba201443_3b3a413562d672490bb32e2ab8917178ba201443/report/index.html

@BiteTheDDDDt BiteTheDDDDt merged commit 7082222 into apache:master Dec 6, 2024
24 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
Speed up function string and add regression
Related PR: #44919
@zclllyybb zclllyybb deleted the opt_space branch December 12, 2024 10:36
dataroaring pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants