-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](nereids) date_add, date_sub, date_diff, date_floor, date_ceil function implement Monotonic #44943
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 40040 ms
|
TPC-DS: Total hot run time: 197571 ms
|
ClickBench: Total hot run time: 33 s
|
run buildall |
TPC-H: Total hot run time: 41557 ms
|
TPC-DS: Total hot run time: 197407 ms
|
ClickBench: Total hot run time: 32.92 s
|
return new DayCeil(literal, child(1), child(2)); | ||
default: | ||
// should not reach | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do LOG
- throw exception or check null in caller
c1871b2
to
e14e305
Compare
…ty, then directly return result.
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
e14e305
to
d0f566b
Compare
run buildall |
TPC-H: Total hot run time: 39518 ms
|
TPC-DS: Total hot run time: 195875 ms
|
ClickBench: Total hot run time: 33.32 s
|
run buildall |
TPC-H: Total hot run time: 39489 ms
|
TPC-DS: Total hot run time: 190421 ms
|
ClickBench: Total hot run time: 32 s
|
run p0 |
PR approved by at least one committer and no changes requested. |
@@ -93,7 +93,7 @@ suite("test_convert_tz") { | |||
} | |||
explain { | |||
sql "SELECT * FROM test_convert_tz WHERE not convert_tz(timestamp, 'Asia/Shanghai', 'Europe/Paris') <= '2021-01-01';"; | |||
contains("partitions=2/3 (p2,p3)") | |||
contains("partitions=3/3 (p1,p2,p3)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test has rollback, we should improve it later
What problem does this PR solve?
date_add, date_sub, date_diff, date_floor, date_ceil function implement Monotonic, so we can do prune range partition for this functions, for example
date_add(dt, 1) = '2024-01-01'
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)