Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](paimon)Remove unnecessary fields #44906

Merged
merged 2 commits into from
Dec 6, 2024
Merged

[opt](paimon)Remove unnecessary fields #44906

merged 2 commits into from
Dec 6, 2024

Conversation

wuwenchi
Copy link
Contributor

@wuwenchi wuwenchi commented Dec 3, 2024 •
edited
Loading

What problem does this PR solve?

Related PR: #44274

Problem Summary:

We have already set the serialization table in TFileScanRangeParams, so there is no need to repeat it for each split.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wuwenchi
Copy link
Contributor Author

wuwenchi commented Dec 3, 2024

run buildall

morningman
morningman previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

PR approved by anyone and no changes requested.

@morningman morningman merged commit 0f74869 into apache:master Dec 6, 2024
24 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
@wuwenchi
[opt](paimon)Remove unnecessary fields (#44906)
8c4c203 
### What problem does this PR solve?

Related PR: #44274

Problem Summary:

We have already set the serialization table in `TFileScanRangeParams`,
so there is no need to repeat it for each split.
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Merged
morningman pushed a commit that referenced this pull request Dec 6, 2024
@github-actions @wuwenchi
branch-3.0: [opt](paimon)Remove unnecessary fields #44906 (#45097)
b50b745 
Cherry-picked from #44906

Co-authored-by: wuwenchi <[email protected]>
wuwenchi added a commit to wuwenchi/doris_new that referenced this pull request Dec 6, 2024
@wuwenchi
[opt](paimon)Remove unnecessary fields (apache#44906)
ec5a9d4 
### What problem does this PR solve?

Related PR: apache#44274

Problem Summary:

We have already set the serialization table in `TFileScanRangeParams`,
so there is no need to repeat it for each split.
@wuwenchi wuwenchi mentioned this pull request Dec 6, 2024
Merged
morningman pushed a commit that referenced this pull request Dec 6, 2024
@wuwenchi
[opt](paimon)Remove unnecessary fields for 2.1 (#44906) (#45118)
9bb9a56 
bp:#44906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@suxiaogang223 suxiaogang223 suxiaogang223 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wuwenchi @doris-robot @morningman @suxiaogang223