Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement helpCommand in nereids #44819

Merged
merged 2 commits into from
Dec 24, 2024
Merged

[Enhancement] (nereids)implement helpCommand in nereids #44819

merged 2 commits into from
Dec 24, 2024

Conversation

msridhar78
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #42824

Related PR: #xxx

Problem Summary:

[Enhancement] (nereids)implement helpCommand in nereids

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39922 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95bbba943ba57ae72afdb020dcbb4cd1a69e97a2, data reload: false

------ Round 1 ----------------------------------
q1	17628	7396	7289	7289
q2	2049	183	168	168
q3	10543	1093	1216	1093
q4	10561	788	724	724
q5	7588	2721	2693	2693
q6	236	148	151	148
q7	985	636	613	613
q8	9250	1841	1942	1841
q9	6655	6590	6492	6492
q10	6945	2299	2331	2299
q11	467	260	255	255
q12	420	222	218	218
q13	17754	3054	3014	3014
q14	243	215	212	212
q15	580	541	518	518
q16	667	597	593	593
q17	977	538	482	482
q18	7217	6563	6589	6563
q19	1330	1009	1026	1009
q20	459	173	176	173
q21	4027	3260	3223	3223
q22	384	325	302	302
Total cold run time: 106965 ms
Total hot run time: 39922 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7284	7264	7265	7264
q2	329	233	226	226
q3	2960	2820	2933	2820
q4	2077	1804	1792	1792
q5	5636	5666	5642	5642
q6	230	140	142	140
q7	2253	1792	1837	1792
q8	3380	3521	3478	3478
q9	8952	8925	8942	8925
q10	3596	3529	3559	3529
q11	590	512	525	512
q12	789	648	621	621
q13	12691	3232	3222	3222
q14	310	269	283	269
q15	577	538	517	517
q16	700	648	630	630
q17	1852	1630	1611	1611
q18	8184	7749	7600	7600
q19	1706	1594	1525	1525
q20	2114	1857	1850	1850
q21	5714	5421	5453	5421
q22	673	608	593	593
Total cold run time: 72597 ms
Total hot run time: 59979 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197267 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95bbba943ba57ae72afdb020dcbb4cd1a69e97a2, data reload: false

query1	1246	943	931	931
query2	6248	2016	1997	1997
query3	10969	4489	4399	4399
query4	68010	28349	23507	23507
query5	4942	446	456	446
query6	405	187	174	174
query7	5500	300	285	285
query8	301	223	217	217
query9	8487	2709	2659	2659
query10	436	239	238	238
query11	16973	15275	15827	15275
query12	152	102	101	101
query13	1444	435	414	414
query14	10864	7793	7512	7512
query15	211	190	193	190
query16	6743	470	473	470
query17	1288	569	573	569
query18	1709	300	291	291
query19	189	146	145	145
query20	123	111	112	111
query21	216	103	103	103
query22	5063	4665	4627	4627
query23	34699	34644	34292	34292
query24	5468	2506	2536	2506
query25	496	374	382	374
query26	634	152	148	148
query27	1796	285	274	274
query28	4458	2491	2453	2453
query29	706	415	401	401
query30	212	152	148	148
query31	934	839	833	833
query32	70	54	52	52
query33	422	288	290	288
query34	930	511	549	511
query35	883	783	762	762
query36	1066	967	950	950
query37	122	82	76	76
query38	4491	4548	4442	4442
query39	1496	1487	1482	1482
query40	212	101	99	99
query41	43	41	42	41
query42	110	95	94	94
query43	536	489	490	489
query44	1202	850	826	826
query45	198	171	164	164
query46	1155	731	704	704
query47	2023	1934	1904	1904
query48	412	308	313	308
query49	731	385	390	385
query50	875	383	404	383
query51	7420	7283	7118	7118
query52	97	88	88	88
query53	251	183	178	178
query54	512	385	391	385
query55	75	73	73	73
query56	250	241	220	220
query57	1257	1101	1118	1101
query58	203	199	211	199
query59	3152	3084	3025	3025
query60	258	239	241	239
query61	121	123	115	115
query62	794	676	671	671
query63	209	188	186	186
query64	1401	719	640	640
query65	3246	3244	3192	3192
query66	703	294	298	294
query67	16080	15916	15722	15722
query68	3963	568	552	552
query69	421	249	251	249
query70	1144	1113	1096	1096
query71	356	241	245	241
query72	6391	4066	4247	4066
query73	771	361	364	361
query74	10262	8918	9020	8918
query75	3418	2680	2697	2680
query76	2248	1042	1046	1042
query77	471	266	260	260
query78	10542	9496	9326	9326
query79	2191	592	597	592
query80	1385	419	425	419
query81	502	231	231	231
query82	1212	207	118	118
query83	232	143	134	134
query84	279	68	73	68
query85	998	295	295	295
query86	422	291	294	291
query87	4895	4697	4508	4508
query88	3512	2194	2182	2182
query89	414	295	298	295
query90	1994	185	182	182
query91	135	100	102	100
query92	68	48	48	48
query93	2871	552	535	535
query94	919	274	294	274
query95	355	242	247	242
query96	636	283	282	282
query97	2881	2665	2664	2664
query98	220	197	193	193
query99	1653	1342	1327	1327
Total cold run time: 321689 ms
Total hot run time: 197267 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.23 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95bbba943ba57ae72afdb020dcbb4cd1a69e97a2, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.07
query4	1.64	0.11	0.10
query5	0.41	0.42	0.41
query6	1.15	0.66	0.65
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.60	0.50	0.50
query10	0.55	0.55	0.56
query11	0.13	0.10	0.11
query12	0.13	0.11	0.12
query13	0.61	0.60	0.60
query14	2.83	2.84	2.83
query15	0.89	0.83	0.83
query16	0.37	0.37	0.40
query17	1.02	1.04	1.03
query18	0.23	0.22	0.21
query19	1.93	1.90	1.97
query20	0.01	0.01	0.00
query21	15.36	0.62	0.59
query22	2.49	1.90	2.23
query23	17.05	0.94	0.84
query24	3.40	1.31	1.24
query25	0.29	0.27	0.12
query26	0.34	0.14	0.14
query27	0.04	0.04	0.04
query28	10.02	1.10	1.07
query29	12.59	3.22	3.23
query30	0.24	0.06	0.07
query31	2.85	0.38	0.37
query32	3.29	0.46	0.46
query33	2.99	3.07	3.11
query34	17.30	4.50	4.50
query35	4.53	4.49	4.48
query36	0.65	0.48	0.47
query37	0.09	0.06	0.05
query38	0.04	0.04	0.04
query39	0.03	0.03	0.02
query40	0.16	0.12	0.13
query41	0.07	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 106.79 s
Total hot run time: 33.23 s

@LiBinfeng-01
Copy link
Collaborator

pls resolved conflicts

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40475 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 27464973a219746dd315b28ad40c6aa1228c73f6, data reload: false

------ Round 1 ----------------------------------
q1	17993	7573	7359	7359
q2	2039	182	188	182
q3	11001	1108	1226	1108
q4	10665	780	702	702
q5	7602	2784	2671	2671
q6	244	149	149	149
q7	1014	655	610	610
q8	9300	1915	1968	1915
q9	6838	6737	6560	6560
q10	7177	2311	2330	2311
q11	491	291	278	278
q12	521	244	241	241
q13	19526	3285	3120	3120
q14	250	213	215	213
q15	577	563	532	532
q16	1111	577	585	577
q17	995	593	544	544
q18	9460	6764	6720	6720
q19	1383	1031	1035	1031
q20	476	181	189	181
q21	4042	3156	3273	3156
q22	389	321	315	315
Total cold run time: 113094 ms
Total hot run time: 40475 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7275	7220	7260	7220
q2	337	238	240	238
q3	3047	2910	2982	2910
q4	2170	1875	1913	1875
q5	5630	5657	5738	5657
q6	229	142	146	142
q7	2255	1786	1850	1786
q8	3439	3416	3548	3416
q9	9038	9003	9007	9003
q10	3597	3542	3601	3542
q11	602	519	505	505
q12	811	644	637	637
q13	14076	3228	3189	3189
q14	315	289	289	289
q15	574	521	520	520
q16	690	639	639	639
q17	1837	1623	1596	1596
q18	8163	7635	7699	7635
q19	1693	1502	1430	1430
q20	2106	1919	1875	1875
q21	5673	5484	5505	5484
q22	646	596	566	566
Total cold run time: 74203 ms
Total hot run time: 60154 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197794 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 27464973a219746dd315b28ad40c6aa1228c73f6, data reload: false

query1	1239	935	953	935
query2	6233	2100	2059	2059
query3	10974	4484	4326	4326
query4	66931	28885	23675	23675
query5	5018	466	450	450
query6	406	215	178	178
query7	5514	311	300	300
query8	338	242	244	242
query9	8509	2657	2647	2647
query10	438	253	252	252
query11	17192	15323	16022	15323
query12	165	103	117	103
query13	1418	449	420	420
query14	10008	7233	7482	7233
query15	229	199	192	192
query16	7108	483	471	471
query17	1429	561	575	561
query18	1860	314	326	314
query19	200	168	150	150
query20	126	113	122	113
query21	196	103	101	101
query22	4726	4713	4596	4596
query23	35248	34555	34501	34501
query24	5524	2605	2468	2468
query25	489	408	387	387
query26	644	157	154	154
query27	1951	288	292	288
query28	4305	2487	2459	2459
query29	674	426	417	417
query30	214	157	156	156
query31	1006	825	828	825
query32	69	63	57	57
query33	410	308	286	286
query34	962	518	520	518
query35	897	777	757	757
query36	1090	944	968	944
query37	125	74	78	74
query38	4414	4393	4459	4393
query39	1530	1489	1474	1474
query40	212	102	100	100
query41	45	42	43	42
query42	114	103	98	98
query43	547	516	497	497
query44	1216	875	845	845
query45	188	169	174	169
query46	1201	727	727	727
query47	2049	1984	1933	1933
query48	419	321	322	321
query49	711	375	385	375
query50	850	412	413	412
query51	7438	7206	7096	7096
query52	96	87	85	85
query53	253	188	181	181
query54	532	408	395	395
query55	77	73	77	73
query56	250	236	230	230
query57	1255	1125	1144	1125
query58	208	223	212	212
query59	3247	3149	3095	3095
query60	269	244	245	244
query61	106	105	104	104
query62	768	683	659	659
query63	212	182	189	182
query64	1377	669	646	646
query65	3268	3203	3260	3203
query66	702	301	303	301
query67	15944	15575	15802	15575
query68	4126	581	556	556
query69	435	249	253	249
query70	1181	1092	1129	1092
query71	355	240	251	240
query72	6404	4221	4039	4039
query73	775	348	359	348
query74	10322	9093	9097	9093
query75	3409	2667	2683	2667
query76	1889	1098	1038	1038
query77	464	292	269	269
query78	10411	9515	9512	9512
query79	1615	596	604	596
query80	855	447	436	436
query81	546	234	238	234
query82	1264	120	118	118
query83	228	140	140	140
query84	280	68	71	68
query85	887	300	307	300
query86	340	299	294	294
query87	4729	4545	4523	4523
query88	3774	2172	2117	2117
query89	423	299	286	286
query90	1985	182	186	182
query91	140	103	101	101
query92	65	49	49	49
query93	1902	557	554	554
query94	782	302	286	286
query95	351	244	251	244
query96	616	270	270	270
query97	2922	2667	2679	2667
query98	229	199	196	196
query99	1613	1320	1306	1306
Total cold run time: 318680 ms
Total hot run time: 197794 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.48 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 27464973a219746dd315b28ad40c6aa1228c73f6, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.04	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.42	0.43	0.41
query6	1.15	0.65	0.65
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.51
query10	0.54	0.55	0.56
query11	0.13	0.10	0.10
query12	0.13	0.12	0.11
query13	0.61	0.61	0.59
query14	2.72	2.85	2.74
query15	0.91	0.84	0.84
query16	0.39	0.40	0.38
query17	1.08	1.03	1.08
query18	0.23	0.21	0.21
query19	1.88	1.80	1.99
query20	0.01	0.01	0.01
query21	15.36	0.60	0.58
query22	2.51	1.76	1.89
query23	17.01	1.14	0.88
query24	3.28	0.96	1.71
query25	0.29	0.08	0.05
query26	0.56	0.14	0.13
query27	0.04	0.04	0.04
query28	10.42	1.11	1.07
query29	12.56	3.24	3.21
query30	0.24	0.06	0.06
query31	2.87	0.38	0.39
query32	3.26	0.48	0.48
query33	3.06	2.99	3.01
query34	16.84	4.46	4.48
query35	4.55	4.51	4.44
query36	0.67	0.51	0.49
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.81 s
Total hot run time: 32.48 s

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40356 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 27464973a219746dd315b28ad40c6aa1228c73f6, data reload: false

------ Round 1 ----------------------------------
q1	17657	7672	7378	7378
q2	2049	176	164	164
q3	10591	1112	1265	1112
q4	10554	730	748	730
q5	7604	2752	2789	2752
q6	239	150	149	149
q7	1002	660	617	617
q8	9248	1917	1926	1917
q9	6745	6614	6617	6614
q10	7014	2274	2318	2274
q11	468	268	270	268
q12	414	224	229	224
q13	17785	3001	3032	3001
q14	245	217	213	213
q15	600	556	534	534
q16	650	570	596	570
q17	1018	600	568	568
q18	7542	6776	6689	6689
q19	1337	989	991	989
q20	481	178	181	178
q21	4043	3217	3098	3098
q22	370	321	317	317
Total cold run time: 107656 ms
Total hot run time: 40356 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7496	7377	7359	7359
q2	340	235	240	235
q3	3001	2999	2954	2954
q4	2111	1839	1854	1839
q5	5658	5715	5721	5715
q6	234	146	142	142
q7	2271	1813	1852	1813
q8	3492	3597	3621	3597
q9	9076	9080	9171	9080
q10	3683	3643	3644	3643
q11	622	518	501	501
q12	766	593	643	593
q13	13089	3297	3295	3295
q14	304	273	286	273
q15	606	553	549	549
q16	697	642	643	642
q17	1919	1676	1661	1661
q18	8573	7839	7752	7752
q19	1696	1453	1415	1415
q20	2163	1928	1868	1868
q21	5631	5562	5393	5393
q22	679	575	574	574
Total cold run time: 74107 ms
Total hot run time: 60893 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196423 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 27464973a219746dd315b28ad40c6aa1228c73f6, data reload: false

query1	1260	950	930	930
query2	6225	2159	2035	2035
query3	11087	4633	4391	4391
query4	67399	28269	23633	23633
query5	4966	478	449	449
query6	413	186	175	175
query7	5522	306	296	296
query8	323	238	245	238
query9	8427	2617	2619	2617
query10	452	246	228	228
query11	17020	15085	15920	15085
query12	165	100	101	100
query13	1429	409	403	403
query14	10353	7036	7277	7036
query15	220	185	190	185
query16	7227	475	490	475
query17	1100	596	577	577
query18	1861	314	317	314
query19	206	159	164	159
query20	125	112	112	112
query21	208	108	108	108
query22	4647	4615	4318	4318
query23	34776	34412	34583	34412
query24	5485	2498	2474	2474
query25	484	381	381	381
query26	645	146	154	146
query27	1995	286	288	286
query28	4557	2470	2470	2470
query29	673	431	435	431
query30	213	151	151	151
query31	1007	838	816	816
query32	65	56	59	56
query33	433	284	296	284
query34	938	513	536	513
query35	901	799	773	773
query36	1080	979	942	942
query37	121	78	67	67
query38	4514	4416	4325	4325
query39	1583	1480	1477	1477
query40	200	99	98	98
query41	44	40	41	40
query42	108	95	103	95
query43	551	510	490	490
query44	1226	827	836	827
query45	191	177	173	173
query46	1166	725	727	725
query47	2042	1956	1939	1939
query48	400	323	316	316
query49	740	392	384	384
query50	872	384	387	384
query51	7413	7336	7026	7026
query52	104	86	87	86
query53	254	177	174	174
query54	508	391	386	386
query55	83	78	74	74
query56	244	224	236	224
query57	1240	1099	1108	1099
query58	217	206	203	203
query59	3164	3171	3026	3026
query60	263	242	240	240
query61	107	106	137	106
query62	808	658	658	658
query63	208	190	194	190
query64	1390	647	615	615
query65	3279	3207	3210	3207
query66	716	289	303	289
query67	16243	15724	15617	15617
query68	3935	584	564	564
query69	423	251	242	242
query70	1190	1159	1132	1132
query71	362	246	251	246
query72	6396	4082	3973	3973
query73	762	359	359	359
query74	10193	8955	9024	8955
query75	3346	2647	2692	2647
query76	1869	1076	1153	1076
query77	493	257	271	257
query78	10502	9529	9324	9324
query79	1389	588	597	588
query80	883	420	415	415
query81	482	238	237	237
query82	1301	122	127	122
query83	248	138	146	138
query84	280	73	75	73
query85	892	298	286	286
query86	341	308	311	308
query87	4689	4627	4648	4627
query88	3630	2166	2114	2114
query89	417	298	300	298
query90	2021	197	186	186
query91	135	102	102	102
query92	68	51	50	50
query93	1906	545	546	545
query94	778	302	359	302
query95	351	238	243	238
query96	602	278	270	270
query97	2874	2690	2691	2690
query98	225	190	194	190
query99	1809	1316	1310	1310
Total cold run time: 318678 ms
Total hot run time: 196423 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.01 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 27464973a219746dd315b28ad40c6aa1228c73f6, data reload: false

query1	0.02	0.03	0.03
query2	0.08	0.04	0.03
query3	0.24	0.07	0.08
query4	1.61	0.10	0.10
query5	0.42	0.41	0.42
query6	1.14	0.65	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.51	0.51
query10	0.56	0.56	0.53
query11	0.14	0.10	0.10
query12	0.14	0.12	0.11
query13	0.62	0.62	0.61
query14	2.79	2.84	2.83
query15	0.92	0.83	0.83
query16	0.38	0.37	0.37
query17	1.06	1.05	1.04
query18	0.22	0.21	0.21
query19	1.89	1.87	2.00
query20	0.02	0.01	0.01
query21	15.36	0.61	0.58
query22	2.82	1.79	2.73
query23	17.06	0.86	0.86
query24	3.15	1.11	1.94
query25	0.28	0.15	0.25
query26	0.39	0.14	0.14
query27	0.04	0.04	0.04
query28	9.63	1.09	1.07
query29	12.62	3.22	3.18
query30	0.27	0.06	0.06
query31	2.87	0.37	0.38
query32	3.26	0.46	0.48
query33	3.02	3.02	3.04
query34	17.03	4.52	4.50
query35	4.64	4.58	4.57
query36	0.68	0.49	0.48
query37	0.09	0.06	0.05
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 106.46 s
Total hot run time: 33.01 s

@msridhar78
Copy link
Contributor Author

run buildall

1 similar comment
@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39494 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 461df0d6418747e10e5a53fb0f4b5920654d5154, data reload: false

------ Round 1 ----------------------------------
q1	17647	7414	7241	7241
q2	2048	177	177	177
q3	10819	1073	1190	1073
q4	10522	789	753	753
q5	7607	2671	2660	2660
q6	237	146	141	141
q7	971	629	593	593
q8	9243	1828	1910	1828
q9	6547	6412	6450	6412
q10	7039	2294	2270	2270
q11	482	276	252	252
q12	423	225	221	221
q13	18289	2987	2878	2878
q14	242	205	219	205
q15	564	506	506	506
q16	674	574	595	574
q17	993	555	565	555
q18	7246	6658	6678	6658
q19	1359	987	839	839
q20	466	183	179	179
q21	3983	3227	3164	3164
q22	389	315	319	315
Total cold run time: 107790 ms
Total hot run time: 39494 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7230	7183	7222	7183
q2	334	230	228	228
q3	2832	2778	2940	2778
q4	2056	1885	1833	1833
q5	5714	5632	5659	5632
q6	228	144	145	144
q7	2263	1805	1848	1805
q8	3377	3528	3445	3445
q9	8837	8930	8924	8924
q10	3556	3518	3524	3518
q11	593	502	524	502
q12	825	575	582	575
q13	11928	3094	3147	3094
q14	320	270	275	270
q15	565	511	507	507
q16	711	668	651	651
q17	1848	1626	1584	1584
q18	8293	7807	7766	7766
q19	1836	1511	1514	1511
q20	2112	1882	1901	1882
q21	5480	5464	5486	5464
q22	640	577	565	565
Total cold run time: 71578 ms
Total hot run time: 59861 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196581 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 461df0d6418747e10e5a53fb0f4b5920654d5154, data reload: false

query1	1285	975	903	903
query2	6252	2342	2356	2342
query3	10964	4519	4642	4519
query4	33489	23695	23334	23334
query5	4616	452	435	435
query6	264	179	176	176
query7	3995	312	299	299
query8	320	266	237	237
query9	9464	2723	2706	2706
query10	478	245	243	243
query11	18049	15090	15109	15090
query12	153	104	100	100
query13	1579	420	409	409
query14	9844	6922	6766	6766
query15	288	211	192	192
query16	8319	451	482	451
query17	1560	608	639	608
query18	2160	305	311	305
query19	216	167	164	164
query20	125	118	117	117
query21	205	109	107	107
query22	4901	4587	4587	4587
query23	34622	34034	34009	34009
query24	11286	2517	2459	2459
query25	677	404	424	404
query26	1746	161	160	160
query27	2848	326	336	326
query28	7727	2483	2479	2479
query29	1033	431	432	431
query30	237	150	155	150
query31	1059	819	838	819
query32	98	55	57	55
query33	790	318	303	303
query34	1022	514	525	514
query35	900	775	791	775
query36	1091	945	953	945
query37	193	72	75	72
query38	4458	4107	4179	4107
query39	1511	1435	1470	1435
query40	270	100	103	100
query41	45	46	43	43
query42	112	110	103	103
query43	547	499	502	499
query44	1338	867	837	837
query45	197	169	176	169
query46	1165	723	735	723
query47	2011	1945	1950	1945
query48	421	342	338	338
query49	1143	440	413	413
query50	824	407	402	402
query51	7360	7267	7136	7136
query52	108	92	93	92
query53	264	192	186	186
query54	1186	431	419	419
query55	86	79	79	79
query56	266	234	247	234
query57	1325	1190	1175	1175
query58	245	224	234	224
query59	3406	3129	3188	3129
query60	289	242	252	242
query61	106	112	108	108
query62	886	684	691	684
query63	224	204	204	204
query64	5133	773	722	722
query65	3298	3239	3263	3239
query66	1352	318	323	318
query67	16086	15513	15581	15513
query68	6122	552	543	543
query69	518	263	248	248
query70	1141	1141	1139	1139
query71	510	257	255	255
query72	6860	4077	4093	4077
query73	798	362	356	356
query74	10009	8828	8863	8828
query75	3723	2644	2629	2629
query76	3845	1049	1062	1049
query77	567	260	290	260
query78	10295	9410	9626	9410
query79	1335	616	595	595
query80	949	422	433	422
query81	509	232	234	232
query82	656	121	123	121
query83	202	139	152	139
query84	283	69	71	69
query85	1361	315	295	295
query86	415	319	297	297
query87	4431	4562	4482	4482
query88	3335	2238	2176	2176
query89	423	294	289	289
query90	2164	185	186	185
query91	144	102	110	102
query92	65	53	52	52
query93	1821	531	538	531
query94	941	274	287	274
query95	337	245	244	244
query96	607	280	287	280
query97	2872	2751	2698	2698
query98	218	203	193	193
query99	1633	1302	1329	1302
Total cold run time: 308606 ms
Total hot run time: 196581 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.55 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 461df0d6418747e10e5a53fb0f4b5920654d5154, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.22	0.07	0.07
query4	1.61	0.10	0.10
query5	0.45	0.40	0.42
query6	1.15	0.65	0.64
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.56	0.50	0.50
query10	0.58	0.58	0.57
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.60	0.60
query14	2.86	2.74	2.72
query15	0.89	0.83	0.84
query16	0.37	0.39	0.38
query17	1.02	1.08	0.98
query18	0.22	0.21	0.22
query19	1.86	1.73	1.99
query20	0.02	0.02	0.01
query21	15.36	0.62	0.60
query22	2.67	3.01	1.51
query23	17.03	0.93	0.75
query24	3.61	0.48	1.47
query25	0.11	0.13	0.06
query26	0.65	0.14	0.13
query27	0.05	0.04	0.04
query28	10.36	1.13	1.08
query29	12.55	3.26	3.24
query30	0.25	0.07	0.06
query31	2.87	0.38	0.38
query32	3.25	0.45	0.46
query33	3.08	3.05	3.15
query34	16.92	4.45	4.48
query35	4.44	4.45	4.43
query36	0.68	0.50	0.48
query37	0.10	0.07	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.12	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.21 s
Total hot run time: 31.55 s

starocean999
starocean999 reviewed Dec 19, 2024
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/HelpCommand.java Outdated
return visitor.visitHelpCommand(this, context);
}

public ShowResultSetMetaData getMetaData() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public ShowResultSetMetaData getMetaData() {

better to remove all 3 getXXXMetaData() methods, and use the member variable directly in doRun method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done - pls review

@msridhar78
Copy link
Contributor Author

run buildall

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39945 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 28cee7fcf1ca3c3af84b23f9d3d32ac257968243, data reload: false

------ Round 1 ----------------------------------
q1	17597	7459	7446	7446
q2	2040	176	170	170
q3	10787	1115	1201	1115
q4	10548	748	728	728
q5	7599	2685	2764	2685
q6	236	153	155	153
q7	1004	633	608	608
q8	9247	1812	1899	1812
q9	6630	6377	6453	6377
q10	7046	2258	2331	2258
q11	475	261	260	260
q12	432	224	231	224
q13	17784	2952	2904	2904
q14	249	213	214	213
q15	571	493	485	485
q16	680	584	604	584
q17	1003	626	501	501
q18	7442	6579	6761	6579
q19	1350	1045	1041	1041
q20	462	185	181	181
q21	4038	3325	3310	3310
q22	378	315	311	311
Total cold run time: 107598 ms
Total hot run time: 39945 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7235	7267	7231	7231
q2	329	226	234	226
q3	2919	2797	2958	2797
q4	2067	1782	1766	1766
q5	5760	5700	5653	5653
q6	230	153	144	144
q7	2284	1832	1828	1828
q8	3414	3576	3520	3520
q9	8954	8959	9007	8959
q10	3586	3547	3541	3541
q11	592	503	546	503
q12	839	646	646	646
q13	11453	3165	3092	3092
q14	323	289	274	274
q15	559	515	505	505
q16	696	642	656	642
q17	1851	1659	1638	1638
q18	8421	7910	7625	7625
q19	1759	1549	1460	1460
q20	2072	1887	1905	1887
q21	5578	5687	5481	5481
q22	656	598	576	576
Total cold run time: 71577 ms
Total hot run time: 59994 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196137 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 28cee7fcf1ca3c3af84b23f9d3d32ac257968243, data reload: false

query1	1314	942	918	918
query2	6222	2476	2360	2360
query3	11068	4970	4784	4784
query4	32885	23335	23419	23335
query5	3626	469	449	449
query6	283	204	188	188
query7	3992	303	312	303
query8	308	238	232	232
query9	9627	2711	2690	2690
query10	445	242	240	240
query11	17701	15107	15411	15107
query12	165	104	104	104
query13	1554	430	412	412
query14	9499	6896	6631	6631
query15	261	206	196	196
query16	7952	458	499	458
query17	1615	593	583	583
query18	2073	304	333	304
query19	228	155	154	154
query20	116	124	114	114
query21	204	111	109	109
query22	4978	4818	4497	4497
query23	34507	33815	33613	33613
query24	11432	2534	2575	2534
query25	647	388	393	388
query26	1434	151	152	151
query27	3245	337	325	325
query28	7734	2456	2460	2456
query29	901	423	405	405
query30	234	154	155	154
query31	1040	826	848	826
query32	94	56	60	56
query33	768	309	289	289
query34	1172	528	522	522
query35	886	765	764	764
query36	1113	965	965	965
query37	153	81	88	81
query38	4214	4177	4093	4093
query39	1503	1469	1461	1461
query40	268	107	110	107
query41	81	47	42	42
query42	123	95	98	95
query43	542	500	502	500
query44	1346	815	848	815
query45	189	166	174	166
query46	1180	703	702	702
query47	2069	1942	1959	1942
query48	420	334	322	322
query49	929	389	375	375
query50	862	404	395	395
query51	7484	7289	7359	7289
query52	106	94	90	90
query53	263	184	182	182
query54	1276	423	425	423
query55	83	84	84	84
query56	284	241	251	241
query57	1332	1137	1144	1137
query58	244	223	225	223
query59	3342	3186	3283	3186
query60	282	244	248	244
query61	109	108	110	108
query62	864	696	697	696
query63	230	193	183	183
query64	5185	688	654	654
query65	3328	3271	3271	3271
query66	1247	305	311	305
query67	16271	15629	15614	15614
query68	5394	569	558	558
query69	474	257	243	243
query70	1226	1085	1099	1085
query71	455	260	247	247
query72	7122	4144	4139	4139
query73	798	361	358	358
query74	10055	8823	8953	8823
query75	3434	2638	2610	2610
query76	3602	1101	1040	1040
query77	579	278	271	271
query78	10278	9383	9967	9383
query79	2093	604	615	604
query80	1121	414	431	414
query81	510	238	221	221
query82	509	116	121	116
query83	192	144	152	144
query84	296	68	68	68
query85	1499	354	302	302
query86	445	301	274	274
query87	4593	4368	4314	4314
query88	3989	2221	2190	2190
query89	424	292	283	283
query90	2095	187	183	183
query91	131	106	104	104
query92	65	118	52	52
query93	1768	541	544	541
query94	905	281	288	281
query95	349	245	239	239
query96	621	281	279	279
query97	2821	2683	2646	2646
query98	218	190	201	190
query99	1631	1313	1293	1293
Total cold run time: 306824 ms
Total hot run time: 196137 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 28cee7fcf1ca3c3af84b23f9d3d32ac257968243, data reload: false

query1	0.03	0.03	0.03
query2	0.10	0.03	0.03
query3	0.24	0.07	0.07
query4	1.60	0.11	0.11
query5	0.42	0.40	0.42
query6	1.16	0.66	0.65
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.58	0.51	0.51
query10	0.57	0.57	0.56
query11	0.15	0.10	0.11
query12	0.13	0.11	0.11
query13	0.61	0.62	0.60
query14	2.86	2.75	2.74
query15	0.91	0.83	0.82
query16	0.40	0.39	0.39
query17	1.08	1.06	1.06
query18	0.22	0.20	0.21
query19	1.86	1.75	2.01
query20	0.02	0.01	0.01
query21	15.36	0.61	0.56
query22	2.75	2.68	1.75
query23	17.32	0.90	0.84
query24	3.25	0.89	1.85
query25	0.30	0.06	0.19
query26	0.37	0.15	0.14
query27	0.03	0.05	0.07
query28	9.98	1.11	1.09
query29	12.58	3.23	3.23
query30	0.25	0.07	0.06
query31	2.87	0.38	0.38
query32	3.26	0.47	0.46
query33	3.13	3.21	3.10
query34	17.22	4.46	4.53
query35	4.52	4.56	4.49
query36	0.68	0.47	0.48
query37	0.10	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.02
query40	0.18	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.04
Total cold run time: 107.39 s
Total hot run time: 32.52 s

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40075 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dc331e383e29d649990425883d688f918a1f7af5, data reload: false

------ Round 1 ----------------------------------
q1	17594	7435	7279	7279
q2	2047	194	191	191
q3	10608	1048	1216	1048
q4	10565	766	705	705
q5	7606	2683	2686	2683
q6	241	156	151	151
q7	996	626	603	603
q8	9244	1860	1887	1860
q9	6605	6415	6407	6407
q10	7000	2341	2314	2314
q11	460	260	259	259
q12	443	222	223	222
q13	18383	3006	2993	2993
q14	254	228	224	224
q15	539	515	496	496
q16	685	593	594	593
q17	982	569	566	566
q18	7488	6901	6881	6881
q19	1385	1053	989	989
q20	470	198	196	196
q21	4070	3107	3129	3107
q22	375	308	313	308
Total cold run time: 108040 ms
Total hot run time: 40075 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7259	7264	7186	7186
q2	326	230	228	228
q3	2871	2828	2944	2828
q4	2052	1817	1860	1817
q5	5642	5628	5598	5598
q6	223	145	145	145
q7	2229	1838	1792	1792
q8	3344	3558	3477	3477
q9	8843	8983	8937	8937
q10	3577	3574	3558	3558
q11	611	509	519	509
q12	818	584	560	560
q13	11734	3168	3075	3075
q14	296	280	282	280
q15	560	515	502	502
q16	684	654	657	654
q17	1856	1610	1608	1608
q18	8319	7847	7758	7758
q19	1779	1460	1644	1460
q20	2103	1873	1844	1844
q21	5616	5475	5481	5475
q22	665	589	575	575
Total cold run time: 71407 ms
Total hot run time: 59866 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196748 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dc331e383e29d649990425883d688f918a1f7af5, data reload: false

query1	1318	945	953	945
query2	6276	2369	2347	2347
query3	11077	4724	4744	4724
query4	33100	23397	23346	23346
query5	4267	451	456	451
query6	277	195	181	181
query7	4001	312	303	303
query8	309	249	266	249
query9	9418	2733	2748	2733
query10	475	267	257	257
query11	17864	15121	15046	15046
query12	160	105	104	104
query13	1580	455	422	422
query14	10082	6691	7192	6691
query15	273	196	211	196
query16	8032	522	523	522
query17	1832	598	563	563
query18	2064	322	321	321
query19	381	160	158	158
query20	131	120	115	115
query21	213	107	109	107
query22	4974	4698	4652	4652
query23	35138	33865	33884	33865
query24	10465	2518	2519	2518
query25	625	404	402	402
query26	1408	153	151	151
query27	2554	342	336	336
query28	7464	2493	2502	2493
query29	835	430	432	430
query30	229	162	155	155
query31	1060	834	860	834
query32	100	57	53	53
query33	773	297	303	297
query34	977	515	515	515
query35	899	763	750	750
query36	1123	964	979	964
query37	149	77	87	77
query38	4346	4155	4226	4155
query39	1520	1448	1446	1446
query40	205	99	104	99
query41	45	43	42	42
query42	109	101	98	98
query43	532	500	508	500
query44	1320	839	836	836
query45	185	171	167	167
query46	1182	724	724	724
query47	1984	1979	1943	1943
query48	440	335	334	334
query49	922	374	396	374
query50	844	387	389	387
query51	7293	7196	7151	7151
query52	107	97	89	89
query53	264	184	192	184
query54	1226	428	424	424
query55	82	76	74	74
query56	252	259	239	239
query57	1253	1170	1162	1162
query58	234	228	229	228
query59	3596	3192	3120	3120
query60	285	243	248	243
query61	111	109	114	109
query62	872	697	696	696
query63	218	185	193	185
query64	3932	728	658	658
query65	3233	3305	3215	3215
query66	718	296	301	296
query67	15819	15555	15642	15555
query68	5795	565	560	560
query69	458	258	250	250
query70	1202	1139	1119	1119
query71	457	252	248	248
query72	6973	4037	4046	4037
query73	785	375	363	363
query74	9812	8841	8854	8841
query75	3409	2661	2657	2657
query76	3802	1048	1093	1048
query77	569	275	278	275
query78	10070	9426	9675	9426
query79	2086	619	608	608
query80	1198	429	441	429
query81	554	243	229	229
query82	628	124	121	121
query83	192	162	144	144
query84	282	80	89	80
query85	1320	311	301	301
query86	412	302	290	290
query87	4717	4330	4349	4330
query88	3690	2234	2220	2220
query89	428	291	288	288
query90	2028	188	193	188
query91	155	109	109	109
query92	64	55	52	52
query93	2373	560	554	554
query94	689	302	291	291
query95	352	252	250	250
query96	620	284	278	278
query97	2886	2647	2684	2647
query98	215	204	196	196
query99	1629	1334	1313	1313
Total cold run time: 304882 ms
Total hot run time: 196748 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.02 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dc331e383e29d649990425883d688f918a1f7af5, data reload: false

query1	0.04	0.05	0.04
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.42	0.42	0.40
query6	1.17	0.64	0.65
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.51
query10	0.56	0.57	0.56
query11	0.14	0.09	0.11
query12	0.15	0.11	0.10
query13	0.60	0.60	0.60
query14	2.86	2.73	2.82
query15	0.89	0.85	0.82
query16	0.38	0.38	0.38
query17	1.06	1.00	1.06
query18	0.23	0.21	0.21
query19	2.00	1.90	1.97
query20	0.01	0.01	0.01
query21	15.36	0.59	0.58
query22	2.53	1.77	2.07
query23	17.08	0.96	0.87
query24	2.64	1.30	1.81
query25	0.24	0.08	0.14
query26	0.53	0.14	0.14
query27	0.05	0.05	0.04
query28	9.93	1.12	1.09
query29	12.61	3.23	3.24
query30	0.25	0.07	0.06
query31	2.85	0.40	0.38
query32	3.23	0.48	0.47
query33	3.13	3.20	3.03
query34	17.14	4.52	4.47
query35	4.52	4.52	4.50
query36	0.67	0.51	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.12	0.14
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.33 s
Total hot run time: 33.02 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 1392084 into apache:master Dec 24, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement helpCommand in nereids
4 participants
@msridhar78 @doris-robot @LiBinfeng-01 @starocean999