Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] (property) Filter table property storage_policy for db sync #44756

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[fix] (property) Filter table property storage_policy for db sync #44756

merged 1 commit into from
Dec 18, 2024

Conversation

wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Nov 28, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close selectdb/ccr-syncer#250

test : selectdb/ccr-syncer#278

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

run buildall

@wyxxxcat wyxxxcat force-pushed the filter_storage_policy branch from 8aed4c4 to fad26a1 Compare November 28, 2024 14:44
@wyxxxcat
Copy link
Contributor Author

run buildall

dataroaring
dataroaring approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@w41ter w41ter merged commit 9a4253f into apache:master Dec 18, 2024
25 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
@wyxxxcat
[fix](restore) Filter table property storage_policy (#44756)
4ad4c08
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
@wyxxxcat
[fix](restore) Filter table property storage_policy (#44756)
e06e650
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Merged
yiguolei pushed a commit that referenced this pull request Dec 18, 2024
@github-actions @wyxxxcat
branch-2.1: [fix] (property) Filter table property storage_policy for…
44e60a9 
… db sync #44756 (#45578)

Cherry-picked from #44756

Co-authored-by: Uniqueyou <[email protected]>
dataroaring pushed a commit that referenced this pull request Dec 23, 2024
@github-actions @wyxxxcat
branch-3.0: [fix] (property) Filter table property storage_policy for…
d8a5ffd 
… db sync #44756 (#45577)

Cherry-picked from #44756

Co-authored-by: Uniqueyou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter w41ter approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] (storage) storage_policy sync problem
5 participants
@wyxxxcat @doris-robot @w41ter @dataroaring @yiguolei