-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] (nereids)implement adminCheckTabletsCommand in nereids… #44701
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
...src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminCheckTabletsCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.trees.plans.commands; | ||
|
|
||
| import org.apache.doris.catalog.Env; | ||
| import org.apache.doris.common.AnalysisException; | ||
| import org.apache.doris.common.DdlException; | ||
| import org.apache.doris.common.ErrorCode; | ||
| import org.apache.doris.common.ErrorReport; | ||
| import org.apache.doris.common.util.PropertyAnalyzer; | ||
| import org.apache.doris.mysql.privilege.PrivPredicate; | ||
| import org.apache.doris.nereids.trees.plans.PlanType; | ||
| import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; | ||
| import org.apache.doris.qe.ConnectContext; | ||
| import org.apache.doris.qe.StmtExecutor; | ||
|
|
||
| import org.apache.commons.collections.CollectionUtils; | ||
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * drop user command | ||
| */ | ||
| public class AdminCheckTabletsCommand extends Command implements ForwardNoSync { | ||
| private static final Logger LOG = LogManager.getLogger(AdminCheckTabletsCommand.class); | ||
| private final List<Long> tabletIds; | ||
| private final Map<String, String> properties; | ||
|
|
||
| /** | ||
| * Check Type in Properties. | ||
| * At present only CONSISTENCY is supported | ||
| */ | ||
| public enum CheckType { | ||
| CONSISTENCY; // check the consistency of replicas of tablet | ||
| public static CheckType getTypeFromString(String str) throws AnalysisException { | ||
| try { | ||
| return CheckType.valueOf(str.toUpperCase()); | ||
| } catch (Exception e) { | ||
| throw new AnalysisException("Unknown check type: " + str); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * constructor | ||
| */ | ||
| // ADMIN CHECK TABLET (id1, id2, ...) PROPERTIES ("type" = "check_consistency"); | ||
| public AdminCheckTabletsCommand(List<Long> tabletIds, Map<String, String> properties) { | ||
| super(PlanType.ADMIN_CHECK_TABLETS_COMMAND); | ||
| this.tabletIds = tabletIds; | ||
| this.properties = properties; | ||
| } | ||
|
|
||
| @Override | ||
| public void run(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
| // check auth | ||
| if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.ADMIN)) { | ||
| ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, "ADMIN"); | ||
| } | ||
|
|
||
| if (CollectionUtils.isEmpty(tabletIds)) { | ||
| throw new AnalysisException("Tablet id list is empty"); | ||
| } | ||
|
|
||
| String typeStr = PropertyAnalyzer.analyzeType(properties); | ||
| if (typeStr == null) { | ||
| throw new AnalysisException("Should specify 'type' property"); | ||
| } | ||
| CheckType checkType = CheckType.getTypeFromString(typeStr); | ||
|
|
||
| if (properties != null && !properties.isEmpty()) { | ||
| throw new AnalysisException("Unknown properties: " + properties.keySet()); | ||
| } | ||
|
|
||
| if (Objects.requireNonNull(checkType) == CheckType.CONSISTENCY) { | ||
| Env.getCurrentEnv().getConsistencyChecker().addTabletsToCheck(tabletIds); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected void checkSupportedInCloudMode(ConnectContext ctx) throws DdlException { | ||
| LOG.info("AdminCheckTabletsCommand not supported in cloud mode"); | ||
| throw new DdlException("Unsupported operation"); | ||
| } | ||
|
|
||
| @Override | ||
| public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { | ||
| return visitor.visitAdminCheckTabletsCommand(this, context); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
regression-test/suites/nereids_p0/admin/test_nereids_admin_check_tablet.groovy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
|
|
||
| suite("test_nereids_admin_check_tablet") { | ||
| def table = "test_nereids_admin_check_tablet" | ||
| // create table and insert data | ||
| sql """ drop table if exists ${table} force""" | ||
| sql """ | ||
| create table ${table} ( | ||
| `id` int(11), | ||
| `name` varchar(128), | ||
| `da` date | ||
| ) | ||
| engine=olap | ||
| duplicate key(id) | ||
| partition by range(da)( | ||
| PARTITION p3 VALUES LESS THAN ('2023-01-01'), | ||
| PARTITION p4 VALUES LESS THAN ('2024-01-01'), | ||
| PARTITION p5 VALUES LESS THAN ('2025-01-01') | ||
| ) | ||
| distributed by hash(id) buckets 2 | ||
| properties( | ||
| "replication_num"="1", | ||
| "light_schema_change"="true" | ||
| ); | ||
| """ | ||
|
|
||
| def tabletId | ||
| def tablets = sql_return_maparray "SHOW TABLETS FROM ${table}" | ||
|
|
||
| for (def tablet : tablets) { | ||
| //get any partition ID. | ||
| tabletId = tablet.TabletId; | ||
| break; | ||
| } | ||
|
|
||
| logger.info("${tabletId}"); | ||
|
|
||
| checkNereidsExecute("ADMIN CHECK TABLET (${tabletId}) PROPERTIES('type' = 'consistency')"); | ||
|
|
||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
override checkSupportedInCloudMode method and implement as checkDdlStmtSupported() method in DdlExecutor.java like bellow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved. Please review