[enhancement]Add comments to block.h and add unit tests #44083
Conversation
…ck_test.cpp and add some initialization for beta_rowset_test.cpp and agg_linear_histogram_test.cpp
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| EXPECT_EQ(0, block.columns()); | ||
| } | ||
|
|
||
| TEST(BlockTest, ColumnOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ColumnOperations) {
^Additional context
be/test/vec/core/block_test.cpp:794: 156 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ColumnOperations) {
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_THROW(multi_null_block.bytes(), Exception); | ||
| } | ||
|
|
||
| TEST(BlockTest, DumpMethods) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
), Exception);
^Additional context
be/test/vec/core/block_test.cpp:1057: 120 lines including whitespace and comments (threshold 80)
), Exception);
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
|
|
||
| // 克隆和列操作测试 | ||
| TEST(BlockTest, CloneOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:1180: 142 lines including whitespace and comments (threshold 80)
}
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, FilterAndSelector) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
.get())->get_data()[0]);
^Additional context
be/test/vec/core/block_test.cpp:1324: 238 lines including whitespace and comments (threshold 80)
.get())->get_data()[0]);
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_EQ(0, other_block.columns()); | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnData) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
_EQ(0, other_block.columns());
^Additional context
be/test/vec/core/block_test.cpp:1603: 123 lines including whitespace and comments (threshold 80)
_EQ(0, other_block.columns());
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { | ||
| // Test case 1: Single column with single value |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
^Additional context
be/test/vec/core/block_test.cpp:1835: 113 lines including whitespace and comments (threshold 80)
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, BlockOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
1_value, hash2.get64());
^Additional context
be/test/vec/core/block_test.cpp:1949: 201 lines including whitespace and comments (threshold 80)
1_value, hash2.get64());
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringAndCompressionOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
olumn->size()); // Kept
^Additional context
be/test/vec/core/block_test.cpp:2152: 113 lines including whitespace and comments (threshold 80)
olumn->size()); // Kept
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_EQ(0, block.columns()); | ||
| } | ||
|
|
||
| TEST(BlockTest, ColumnOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ColumnOperations) {
^Additional context
be/test/vec/core/block_test.cpp:790: 156 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ColumnOperations) {
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_THROW(multi_null_block.bytes(), Exception); | ||
| } | ||
|
|
||
| TEST(BlockTest, DumpMethods) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, DumpMethods) {
^Additional context
be/test/vec/core/block_test.cpp:1052: 121 lines including whitespace and comments (threshold 80)
TEST(BlockTest, DumpMethods) {
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CloneOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CloneOperations) {
^Additional context
be/test/vec/core/block_test.cpp:1175: 142 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CloneOperations) {
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, FilterAndSelector) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, FilterAndSelector) {
^Additional context
be/test/vec/core/block_test.cpp:1319: 238 lines including whitespace and comments (threshold 80)
TEST(BlockTest, FilterAndSelector) {
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_EQ(0, other_block.columns()); | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnData) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ClearColumnData) {
^Additional context
be/test/vec/core/block_test.cpp:1598: 122 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ClearColumnData) {
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_EQ(2, col2->get_data()[0]); // the value of col2 should be 2 | ||
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:1828: 113 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, BlockOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, BlockOperations) {
^Additional context
be/test/vec/core/block_test.cpp:1943: 201 lines including whitespace and comments (threshold 80)
TEST(BlockTest, BlockOperations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, StringOperations) {
^Additional context
be/test/vec/core/block_test.cpp:2146: 99 lines including whitespace and comments (threshold 80)
TEST(BlockTest, StringOperations) {
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_THROW(multi_null_block.bytes(), Exception); | ||
| } | ||
|
|
||
| TEST(BlockTest, DumpMethods) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, DumpMethods) {
^Additional context
be/test/vec/core/block_test.cpp:1052: 122 lines including whitespace and comments (threshold 80)
TEST(BlockTest, DumpMethods) {
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CloneOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CloneOperations) {
^Additional context
be/test/vec/core/block_test.cpp:1176: 159 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CloneOperations) {
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, FilterAndSelector) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, FilterAndSelector) {
^Additional context
be/test/vec/core/block_test.cpp:1337: 236 lines including whitespace and comments (threshold 80)
TEST(BlockTest, FilterAndSelector) {
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_EQ(0, other_block.columns()); | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnData) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ClearColumnData) {
^Additional context
be/test/vec/core/block_test.cpp:1614: 122 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ClearColumnData) {
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_EQ(2, col2->get_data()[0]); // the value of col2 should be 2 | ||
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:1844: 113 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, BlockOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, BlockOperations) {
^Additional context
be/test/vec/core/block_test.cpp:1959: 201 lines including whitespace and comments (threshold 80)
TEST(BlockTest, BlockOperations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, StringOperations) {
^Additional context
be/test/vec/core/block_test.cpp:2162: 99 lines including whitespace and comments (threshold 80)
TEST(BlockTest, StringOperations) {
^
| EXPECT_EQ(0, other_block.columns()); | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnData) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ClearColumnData) {
^Additional context
be/test/vec/core/block_test.cpp:1613: 122 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ClearColumnData) {
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_EQ(2, col2->get_data()[0]); // the value of col2 should be 2 | ||
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:1843: 113 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, BlockOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, BlockOperations) {
^Additional context
be/test/vec/core/block_test.cpp:1958: 201 lines including whitespace and comments (threshold 80)
TEST(BlockTest, BlockOperations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, StringOperations) {
^Additional context
be/test/vec/core/block_test.cpp:2161: 99 lines including whitespace and comments (threshold 80)
TEST(BlockTest, StringOperations) {
^
|
run buildall |
There was a problem hiding this comment.
We can by the way unify the format, and the function is not related to the large paragraph description with /**/, and then the function of the comments are unified with //, if some kind of function categorisation of the comments can be used /// (for example, "the following is the query interface", etc.)
TPC-H: Total hot run time: 45805 ms |
ClickBench: Total hot run time: 32.13 s |
|
run buildall |
TPC-H: Total hot run time: 45272 ms |
ClickBench: Total hot run time: 33.24 s |
…pty, regular, const, and nullable columns
…n empty, regular, const, and nullable columns, ensuring correct order and data preservation.
… regular, const, and nullable columns, ensuring consistent hash values for identical data and different hashes for varying data arrangements.
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, BasicOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, BasicOperations) {
^Additional context
be/test/vec/core/block_test.cpp:778: 250 lines including whitespace and comments (threshold 80)
TEST(BlockTest, BasicOperations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ColumnOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ColumnOperations) {
^Additional context
be/test/vec/core/block_test.cpp:1030: 286 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ColumnOperations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, SortColumns) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, SortColumns) {
^Additional context
be/test/vec/core/block_test.cpp:1318: 152 lines including whitespace and comments (threshold 80)
TEST(BlockTest, SortColumns) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, RowOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, RowOperations) {
^Additional context
be/test/vec/core/block_test.cpp:1472: 154 lines including whitespace and comments (threshold 80)
TEST(BlockTest, RowOperations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, MemoryAndSize) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, MemoryAndSize) {
^Additional context
be/test/vec/core/block_test.cpp:1628: 175 lines including whitespace and comments (threshold 80)
TEST(BlockTest, MemoryAndSize) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnData) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ClearColumnData) {
^Additional context
be/test/vec/core/block_test.cpp:3307: 244 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ClearColumnData) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, IndexByName) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, IndexByName) {
^Additional context
be/test/vec/core/block_test.cpp:3553: 184 lines including whitespace and comments (threshold 80)
TEST(BlockTest, IndexByName) {
^
be/test/vec/core/block_test.cpp
Outdated
| EXPECT_EQ(2, col2->get_data()[0]); // the value of col2 should be 2 | ||
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:3797: 113 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, BlockOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, BlockOperations) {
^Additional context
be/test/vec/core/block_test.cpp:3912: 201 lines including whitespace and comments (threshold 80)
TEST(BlockTest, BlockOperations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, StringOperations) {
^Additional context
be/test/vec/core/block_test.cpp:4115: 99 lines including whitespace and comments (threshold 80)
TEST(BlockTest, StringOperations) {
^
| EXPECT_EQ("col1", block.get_by_position(1).name); | ||
|
|
||
| // Verify column data is correctly shuffled | ||
| const auto* col1 = assert_cast<const vectorized::ColumnVector<Int32>*>( |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:3777: 113 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^
be/test/vec/core/block_test.cpp
Outdated
| // Test case 1: Single column with single value | ||
| { | ||
| vectorized::Block block; | ||
| auto col = vectorized::ColumnVector<Int32>::create(); |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, BlockOperations) {
^Additional context
be/test/vec/core/block_test.cpp:3892: 201 lines including whitespace and comments (threshold 80)
TEST(BlockTest, BlockOperations) {
^| col1->insert_value(1); | ||
| col1->insert_value(3); | ||
| block2.insert({std::move(col1), type, "col1"}); | ||
|
|
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, StringOperations) {
^Additional context
be/test/vec/core/block_test.cpp:4095: 99 lines including whitespace and comments (threshold 80)
TEST(BlockTest, StringOperations) {
^| TEST(BlockTest, StringOperations) { | ||
| using namespace std::string_literals; | ||
| // Test shrink_char_type_column_suffix_zero | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, dump_data) {
^Additional context
be/test/vec/core/block_test.cpp:4209: 90 lines including whitespace and comments (threshold 80)
TEST(BlockTest, dump_data) {
^| col->insert_value(2); | ||
| auto type = std::make_shared<vectorized::DataTypeInt32>(); | ||
| block.insert({std::move(col), type, "int_col"}); | ||
| } |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
| } | |
| auto value = __int128_t(i * pow(10, 9) + i * pow(10, 8)); |
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ColumnTransformations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ColumnTransformations) {
^Additional context
be/test/vec/core/block_test.cpp:3739: 147 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ColumnTransformations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:3888: 113 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^
be/test/vec/core/block_test.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, BlockOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, BlockOperations) {
^Additional context
be/test/vec/core/block_test.cpp:4003: 201 lines including whitespace and comments (threshold 80)
TEST(BlockTest, BlockOperations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, StringOperations) {
^Additional context
be/test/vec/core/block_test.cpp:4206: 99 lines including whitespace and comments (threshold 80)
TEST(BlockTest, StringOperations) {
^…are methods, same bit operations, and temporary column management across empty, regular, const, and nullable columns, ensuring robust functionality and data integrity.
…luding shrinking string columns with trailing zeros and verifying data integrity across various scenarios, such as empty strings and array columns.
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:3888: 343 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CompareAt) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CompareAt) {
^Additional context
be/test/vec/core/block_test.cpp:4308: 193 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CompareAt) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CompareColumnAt) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CompareColumnAt) {
^Additional context
be/test/vec/core/block_test.cpp:4503: 153 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CompareColumnAt) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, SameBitOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
< null
^Additional context
be/test/vec/core/block_test.cpp:4658: 100 lines including whitespace and comments (threshold 80)
< null
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CreateSameStructBlock) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4760: 147 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, EraseTmpColumns) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4909: 135 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnMemNotKeep) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5046: 145 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5193: 99 lines including whitespace and comments (threshold 80)
}
^
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CloneOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CloneOperations) {
^Additional context
be/test/vec/core/block_test.cpp:2078: 296 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CloneOperations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, FilterAndSelector) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, FilterAndSelector) {
^Additional context
be/test/vec/core/block_test.cpp:2376: 766 lines including whitespace and comments (threshold 80)
TEST(BlockTest, FilterAndSelector) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, RowCheck) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, RowCheck) {
^Additional context
be/test/vec/core/block_test.cpp:3144: 167 lines including whitespace and comments (threshold 80)
TEST(BlockTest, RowCheck) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnData) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ClearColumnData) {
^Additional context
be/test/vec/core/block_test.cpp:3313: 244 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ClearColumnData) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, IndexByName) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, IndexByName) {
^Additional context
be/test/vec/core/block_test.cpp:3559: 184 lines including whitespace and comments (threshold 80)
TEST(BlockTest, IndexByName) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, SameBitOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
< null
^Additional context
be/test/vec/core/block_test.cpp:4664: 100 lines including whitespace and comments (threshold 80)
< null
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CreateSameStructBlock) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4766: 147 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, EraseTmpColumns) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4915: 135 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnMemNotKeep) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5052: 145 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5199: 155 lines including whitespace and comments (threshold 80)
}
^
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, FilterAndSelector) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, FilterAndSelector) {
^Additional context
be/test/vec/core/block_test.cpp:2376: 772 lines including whitespace and comments (threshold 80)
TEST(BlockTest, FilterAndSelector) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, RowCheck) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, RowCheck) {
^Additional context
be/test/vec/core/block_test.cpp:3150: 167 lines including whitespace and comments (threshold 80)
TEST(BlockTest, RowCheck) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnData) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ClearColumnData) {
^Additional context
be/test/vec/core/block_test.cpp:3319: 244 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ClearColumnData) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, IndexByName) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, IndexByName) {
^Additional context
be/test/vec/core/block_test.cpp:3565: 184 lines including whitespace and comments (threshold 80)
TEST(BlockTest, IndexByName) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ColumnTransformations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ColumnTransformations) {
^Additional context
be/test/vec/core/block_test.cpp:3751: 147 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ColumnTransformations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, SameBitOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
< null
^Additional context
be/test/vec/core/block_test.cpp:4670: 100 lines including whitespace and comments (threshold 80)
< null
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CreateSameStructBlock) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4772: 147 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, EraseTmpColumns) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4921: 135 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnMemNotKeep) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5058: 145 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5205: 155 lines including whitespace and comments (threshold 80)
}
^
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnData) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ClearColumnData) {
^Additional context
be/test/vec/core/block_test.cpp:3319: 245 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ClearColumnData) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, IndexByName) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, IndexByName) {
^Additional context
be/test/vec/core/block_test.cpp:3566: 185 lines including whitespace and comments (threshold 80)
TEST(BlockTest, IndexByName) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ColumnTransformations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ColumnTransformations) {
^Additional context
be/test/vec/core/block_test.cpp:3753: 147 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ColumnTransformations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:3902: 343 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CompareAt) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CompareAt) {
^Additional context
be/test/vec/core/block_test.cpp:4322: 193 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CompareAt) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, SameBitOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
< null
^Additional context
be/test/vec/core/block_test.cpp:4675: 100 lines including whitespace and comments (threshold 80)
< null
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CreateSameStructBlock) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4777: 147 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, EraseTmpColumns) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4926: 141 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnMemNotKeep) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5069: 145 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5216: 144 lines including whitespace and comments (threshold 80)
}
^
|
|
||
| TEST(BlockTest, IndexByName) { | ||
| // Test with empty block | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, IndexByName) {
^Additional context
be/test/vec/core/block_test.cpp:3565: 185 lines including whitespace and comments (threshold 80)
TEST(BlockTest, IndexByName) {
^|
|
||
| TEST(BlockTest, ColumnTransformations) { | ||
| // Test with empty block | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ColumnTransformations) {
^Additional context
be/test/vec/core/block_test.cpp:3752: 147 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ColumnTransformations) {
^
be/test/vec/core/block_test.cpp
Outdated
|
|
||
| TEST(BlockTest, HashUpdate) { | ||
| // Test with empty block | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:3901: 343 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^|
|
||
| TEST(BlockTest, CompareAt) { | ||
| // Test with empty blocks | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CompareAt) {
^Additional context
be/test/vec/core/block_test.cpp:4321: 193 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CompareAt) {
^|
|
||
| TEST(BlockTest, CompareColumnAt) { | ||
| // Test with empty blocks | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CompareColumnAt) {
^Additional context
be/test/vec/core/block_test.cpp:4516: 156 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CompareColumnAt) {
^|
|
||
| TEST(BlockTest, SameBitOperations) { | ||
| // Test with empty block | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
< null
^Additional context
be/test/vec/core/block_test.cpp:4674: 100 lines including whitespace and comments (threshold 80)
< null
^|
|
||
| TEST(BlockTest, CreateSameStructBlock) { | ||
| // Test with empty block | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4776: 147 lines including whitespace and comments (threshold 80)
}
^|
|
||
| TEST(BlockTest, EraseTmpColumns) { | ||
| // Test with empty block | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4925: 141 lines including whitespace and comments (threshold 80)
}
^|
|
||
| TEST(BlockTest, ClearColumnMemNotKeep) { | ||
| // Test with empty block | ||
| { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5068: 145 lines including whitespace and comments (threshold 80)
}
^|
|
||
| TEST(BlockTest, StringOperations) { | ||
| using namespace std::string_literals; | ||
|
|
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5215: 144 lines including whitespace and comments (threshold 80)
}
^
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnData) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ClearColumnData) {
^Additional context
be/test/vec/core/block_test.cpp:3319: 242 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ClearColumnData) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, IndexByName) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, IndexByName) {
^Additional context
be/test/vec/core/block_test.cpp:3563: 185 lines including whitespace and comments (threshold 80)
TEST(BlockTest, IndexByName) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ColumnTransformations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, ColumnTransformations) {
^Additional context
be/test/vec/core/block_test.cpp:3750: 147 lines including whitespace and comments (threshold 80)
TEST(BlockTest, ColumnTransformations) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:3899: 343 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CompareAt) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CompareAt) {
^Additional context
be/test/vec/core/block_test.cpp:4319: 193 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CompareAt) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, SameBitOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
< null
^Additional context
be/test/vec/core/block_test.cpp:4672: 100 lines including whitespace and comments (threshold 80)
< null
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CreateSameStructBlock) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4774: 147 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, EraseTmpColumns) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4923: 141 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, ClearColumnMemNotKeep) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5066: 145 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5213: 144 lines including whitespace and comments (threshold 80)
}
^
| } | ||
| } | ||
|
|
||
| TEST(BlockTest, HashUpdate) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, HashUpdate) {
^Additional context
be/test/vec/core/block_test.cpp:3899: 337 lines including whitespace and comments (threshold 80)
TEST(BlockTest, HashUpdate) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CompareAt) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CompareAt) {
^Additional context
be/test/vec/core/block_test.cpp:4313: 193 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CompareAt) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CompareColumnAt) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(BlockTest, CompareColumnAt) {
^Additional context
be/test/vec/core/block_test.cpp:4508: 156 lines including whitespace and comments (threshold 80)
TEST(BlockTest, CompareColumnAt) {
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, SameBitOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
< null
^Additional context
be/test/vec/core/block_test.cpp:4666: 100 lines including whitespace and comments (threshold 80)
< null
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, CreateSameStructBlock) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:4768: 145 lines including whitespace and comments (threshold 80)
}
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, EraseTmpColumns) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
e));
^Additional context
be/test/vec/core/block_test.cpp:4915: 141 lines including whitespace and comments (threshold 80)
e));
^| } | ||
| } | ||
|
|
||
| TEST(BlockTest, StringOperations) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
}
^Additional context
be/test/vec/core/block_test.cpp:5205: 144 lines including whitespace and comments (threshold 80)
}
^
|
run buildall |
TPC-H: Total hot run time: 39826 ms |
TPC-DS: Total hot run time: 196643 ms |
ClickBench: Total hot run time: 32.98 s |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)